GC: clean up the maintained list of extra updates on onClear event (#1)

martin-georgiev · web-flow · commit 280208e3ac8a · 2019-01-29T16:25:52.000Z
diff --git a/src/SimpleThings/EntityAudit/EventListener/LogRevisionsListener.php b/src/SimpleThings/EntityAudit/EventListener/LogRevisionsListener.php
@@ -96,7 +96,7 @@ public function __construct(AuditManager $auditManager)
 
     public function getSubscribedEvents()
     {
-        return array(Events::onFlush, Events::postPersist, Events::postUpdate, Events::postFlush);
+        return array(Events::onFlush, Events::postPersist, Events::postUpdate, Events::postFlush, Events::onClear);
     }
 
     /**
@@ -241,6 +241,11 @@ public function postUpdate(LifecycleEventArgs $eventArgs)
         $this->saveRevisionEntityData($class, $entityData, 'UPD');
     }
 
+    public function onClear()
+    {
+        $this->extraUpdates = array();
+    }
+
     public function onFlush(OnFlushEventArgs $eventArgs)
     {
         $this->em = $eventArgs->getEntityManager();

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ public function __construct(AuditManager $auditManager)`
`96`	`96`
`97`	`97`	`public function getSubscribedEvents()`
`98`	`98`	`{`
`99`		`- return array(Events::onFlush, Events::postPersist, Events::postUpdate, Events::postFlush);`
	`99`	`+ return array(Events::onFlush, Events::postPersist, Events::postUpdate, Events::postFlush, Events::onClear);`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`/**`
`@@ -241,6 +241,11 @@ public function postUpdate(LifecycleEventArgs $eventArgs)`
`241`	`241`	`$this->saveRevisionEntityData($class, $entityData, 'UPD');`
`242`	`242`	`}`
`243`	`243`
	`244`	`+ public function onClear()`
	`245`	`+ {`
	`246`	`+ $this->extraUpdates = array();`
	`247`	`+ }`
	`248`	`+`
`244`	`249`	`public function onFlush(OnFlushEventArgs $eventArgs)`
`245`	`250`	`{`
`246`	`251`	`$this->em = $eventArgs->getEntityManager();`