Merge pull request #40 from aligent/fix/39-multiple-resources-endpoint

jswift · web-flow · commit d4989ff70963 · 2021-03-24T16:26:58.000+10:30
Fix fatal error in getAllPages() on PHP 7
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -1,4 +1,3 @@
-### New Features
+### Bug Fix
 
-Implement the new (Custom Template Associations)[https://developer.bigcommerce.com/api-reference/store-management/custom-template-associations]
-API.
+Fix issue with all batch operations under PHP 7.4
diff --git a/src/BigCommerce/Api/Generic/BatchUpdateResource.php b/src/BigCommerce/Api/Generic/BatchUpdateResource.php
@@ -10,7 +10,7 @@
 trait BatchUpdateResource
 {
     abstract public function batchUpdate(array $resources): PaginatedResponse;
-    abstract public function multipleResourcesEndpoint(): string;
+    abstract protected function multipleResourcesEndpoint(): string;
     abstract public function getClient(): Client;
 
     protected function maxBatchSize(): int

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`trait BatchUpdateResource`
`11`	`11`	`{`
`12`	`12`	`abstract public function batchUpdate(array $resources): PaginatedResponse;`
`13`		`- abstract public function multipleResourcesEndpoint(): string;`
	`13`	`+ abstract protected function multipleResourcesEndpoint(): string;`
`14`	`14`	`abstract public function getClient(): Client;`
`15`	`15`
`16`	`16`	`protected function maxBatchSize(): int`