Skip to content

feat(error): add gas limit fns to InvalidTxError trait #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mablr wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(error): add gas limit fns to InvalidTxError trait #235

mablr wants to merge 4 commits into from

Conversation

@mablr
Copy link
Contributor

@mablr mablr commented Nov 27, 2025 •
edited
Loading

Motivation

Towards #225

This would allow to get rid of AsEthApiError trait and its impls in Reth https://github.com/paradigmxyz/reth/blob/6598b88e0278a084eabad44573298d5f097b9244/crates/rpc/rpc-eth-types/src/error/api.rs#L53

Solution

  • Add is_gas_limit_too_high and is_gas_limit_too_high fns to InvalidTxError trait
  • Add default impls to InvalidTxError trait using as_invalid_tx_err

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@mablr mablr requested review from klkvr and mattsse as code owners November 27, 2025 23:48
mattsse
mattsse approved these changes Nov 28, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

pending @klkvr

klkvr
klkvr requested changes Nov 28, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse approved these changes

@klkvr klkvr klkvr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mablr @mattsse @klkvr