Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit and continue does not work due to usage of AspectInjector 2.6 #304

Open
1 of 3 tasks
andrematosfundao opened this issue Nov 24, 2022 · 4 comments
Open
1 of 3 tasks
Labels

Comments

@andrematosfundao
Copy link

I'm submitting a ...

  • bug report
  • feature request
  • support request => Please do not submit support request here, see note at the top of this template.

What is the current behavior?

Cannot use edit and continue on debug mode when allureStepAttribute is used

see this video of the failure

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

in the code bellow put a break point on the test
run in debug mode
edit the string
continue execution
it fails

code example

What is the expected behavior?

we should be able to use edit and continue since it is such a great tool for development

What is the motivation / use case for changing the behavior?

making edit and continue work as expected.

Please tell us about your environment:

<TargetFramework>net7.0</TargetFramework>

<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
<PackageReference Include="NUnit" Version="3.13.3" />
<PackageReference Include="NUnit3TestAdapter" Version="4.2.1" />
<PackageReference Include="NUnit.Analyzers" Version="3.3.0" />
<PackageReference Include="NUnit.Allure" Version="1.2.1.1" />

Other information

I believe to fix this it is only necessary to update to AspectInjector 2.7

as a temporary fix i copied the code for AllureStepAttribute in my project and use the latest aspectInjector and that works for me.

@neparij
Copy link
Contributor

neparij commented Dec 20, 2022

@andrematosfundao Hi!
Yes, this is known issue pamidur/aspect-injector#138
I'll bump AspectInjector version in next release!
Thanks!

@neparij
Copy link
Contributor

neparij commented Dec 23, 2022

Hello everyone!
You can try it out in 2.9.3-preview.1 release

@andrematosfundao
Copy link
Author

hello there @neparij, i updated to the 2.9.3-preview.1 version and i see the same problem, when allurestep is used edit and continue stops working:
image

@delatrie delatrie added the bug label Jul 10, 2023
@andrematosfundao
Copy link
Author

hello there, just to mention this is still a issue on 2.10
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants