Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata is missing on update from 2.15.1 to 3.1.0 #1240

Closed
antoniidaraiev opened this issue Feb 1, 2025 · 1 comment · Fixed by #1244
Closed

Metadata is missing on update from 2.15.1 to 3.1.0 #1240

antoniidaraiev opened this issue Feb 1, 2025 · 1 comment · Fixed by #1244
Assignees
@epszaw

Comments

@antoniidaraiev
Copy link

antoniidaraiev commented Feb 1, 2025 •
edited
Loading

Describe the bug

  1. Trying to update allure-playwright form 2.15.1 to 3.1.0 and Metadata such as SessionId, Os, Region and Browser are not presented like it was before. (Same happens on 3.08 and 3.0.9, so unsure when exactly it started to fail) Screenshot 1, 2
  2. In addition, the failed step has a green color when collapsed, makes it hard to find actual failure. And attachments now in the failed step, not in the end of the execution. (Guess it's expected?) Screenshot 3, 4

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
3.1.0 - missing meta
Image
2.15.1 - meta is present, attachments at the end of the execution
Image

3.1.0 - Step: page wait for event has failed but it's green when collapsed.
Image
When expanded, you can see the failure
Image

Desktop (please complete the following information):

  • Browser [chrome - 132]
  • Playwright [v-1.49.1]
@epszaw epszaw mentioned this issue Feb 4, 2025
Merged
2 tasks
@epszaw
Copy link
Member

epszaw commented Feb 7, 2025

Hey there! Thank you for the issue!
I did a fix of the problem with incorrect steps statuses, you can see it in the PR above. The fix makes the report structure very close to the Playwright HTML report (also excludes some system steps, like Worker Cleanup).
If we discuss the problem of providing metadata as an attachment for each test – it's a breaking change we won't fix for next reasons:

  • the provided environment info can be found on the overview page in the Environment widget because the data relates to the entire report
  • duplication of attachments with the same content will increase the end report's size, but we have to keep the report as small as it's possible

baev pushed a commit that referenced this issue Feb 10, 2025
@epszaw
fix(playwright): fix step statuses and tests structure (fixes #1240, …
da8f17f 
…via #1244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epszaw epszaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix playwright step statuses and tests structure allure-framework/allure-js
2 participants
@epszaw @antoniidaraiev