feat(rename_variable,js): add rename variable on javascript

Author: alquerci

README.md

@@ -11,11 +11,13 @@ A set of mappings which help you to refactor code in consistent way across langu
 ## Supported languages
 
 - PHP
-- SH
+- Shell
   - Extract Method
-- JS
+- JavaScript
   - Extract Method
   - Extract Variable
+  - Inline Variable
+  - Rename Variable
 - TypeScript
   - Extract Method
   - Extract Variable

autoload/refactoring_toolbox/extract_method/main.vim

@@ -30,7 +30,7 @@ function refactoring_toolbox#extract_method#main#extractMethodForSh() range
     \ )
 endfunction
 
-function refactoring_toolbox#extract_method#main#extractMethodForJavaScript() range
+function refactoring_toolbox#extract_method#main#extractMethodForJavascript() range
     call refactoring_toolbox#usage#increment('JsExtractMethod')
 
     call refactoring_toolbox#extract_method#method_extractor#extractSelectedBlock(

autoload/refactoring_toolbox/extract_variable/main.vim

@@ -9,7 +9,7 @@ function refactoring_toolbox#extract_variable#main#execute() range
     \ )
 endfunction
 
-function refactoring_toolbox#extract_variable#main#extractVariableForJavaScript() range
+function refactoring_toolbox#extract_variable#main#extractVariableForJavascript() range
     call refactoring_toolbox#usage#increment('JsExtractVariable')
 
     call refactoring_toolbox#extract_variable#variable_extractor#execute(

autoload/refactoring_toolbox/inline_variable/main.vim

@@ -10,7 +10,7 @@ function refactoring_toolbox#inline_variable#main#execute()
     \ )
 endfunction
 
-function refactoring_toolbox#inline_variable#main#inlineVariableForJavaScript()
+function refactoring_toolbox#inline_variable#main#inlineVariableForJavascript()
     call refactoring_toolbox#usage#increment('JsInlineVariable')
 
     call refactoring_toolbox#inline_variable#variable_inliner#execute(

autoload/refactoring_toolbox/rename_variable/adapters/js_language.vim

@@ -0,0 +1,34 @@
+let s:regex_func_line = refactoring_toolbox#adapters#js_regex#func_line
+
+call refactoring_toolbox#adapters#vim#begin_script()
+
+function refactoring_toolbox#rename_variable#adapters#js_language#make()
+    return s:self
+endfunction
+
+let s:self = #{}
+
+function s:self.parseVariable(word)
+    return a:word
+endfunction
+
+function s:self.formatVariable(name)
+    return a:name
+endfunction
+
+function s:self.findCurrentFunctionLineRange()
+    let l:backupPosition = getcurpos()
+
+    call search(s:regex_func_line, 'beW')
+    let l:startLine = line('.')
+
+    call search('{', 'Wc')
+    call searchpair('{', '', '}', 'W')
+    let l:stopLine = line('.')
+
+    call setpos('.', l:backupPosition)
+
+    return [l:startLine, l:stopLine]
+endfunction
+
+call refactoring_toolbox#adapters#vim#end_script()

autoload/refactoring_toolbox/rename_variable/main.vim

@@ -22,6 +22,17 @@ function refactoring_toolbox#rename_variable#main#renameLocalVariable()
     \ )
 endfunction
 
+function refactoring_toolbox#rename_variable#main#renameVariableForJavascript()
+    call refactoring_toolbox#usage#increment('JsRenameVariable')
+
+    call refactoring_toolbox#rename_variable#variable_renamer#execute(
+        \ refactoring_toolbox#rename_variable#adapters#js_language#make(),
+        \ refactoring_toolbox#adapters#input#make(),
+        \ refactoring_toolbox#adapters#output#make(),
+        \ refactoring_toolbox#adapters#vim_texteditor#make(),
+    \ )
+endfunction
+
 function refactoring_toolbox#rename_variable#main#renameVariableForTypescript()
     call refactoring_toolbox#usage#increment('TsRenameVariable')
 

doc/refactoring-toolbox.txt

@@ -29,11 +29,13 @@ A set of mappings which help you to refactor code in consistent way across langu
 Supported languages:
 
 - PHP
-- SH
+- Shell
   - Extract Method
-- JS
+- JavaScript
   - Extract Method
   - Extract Variable
+  - Inline Variable
+  - Rename Variable
 - TypeScript
   - Extract Method
   - Extract Variable

ftplugin/javascript/refactoring-toolbox.vim

@@ -9,19 +9,25 @@ function s:registerMappings()
         call s:addBufferVisualMapping(
             \ '<LocalLeader>em',
             \ '<Plug>refactoring_toolbox_javascript_ExtractMethod',
-            \ 'refactoring_toolbox#extract_method#main#extractMethodForJavaScript()'
+            \ 'refactoring_toolbox#extract_method#main#extractMethodForJavascript()'
         \ )
 
         call s:addBufferVisualMapping(
             \ '<LocalLeader>ev',
             \ '<Plug>refactoring_toolbox_javascript_ExtractVariable',
-            \ 'refactoring_toolbox#extract_variable#main#extractVariableForJavaScript()'
+            \ 'refactoring_toolbox#extract_variable#main#extractVariableForJavascript()'
         \ )
 
         call s:addBufferNormalMapping(
             \ '<LocalLeader>iv',
             \ '<Plug>refactoring_toolbox_javascript_InlineVariable',
-            \ 'refactoring_toolbox#inline_variable#main#inlineVariableForJavaScript()'
+            \ 'refactoring_toolbox#inline_variable#main#inlineVariableForJavascript()'
+        \ )
+
+        call s:addBufferNormalMapping(
+            \ '<LocalLeader>rv',
+            \ '<Plug>refactoring_toolbox_javascript_RenameVariable',
+            \ 'refactoring_toolbox#rename_variable#main#renameVariableForJavascript()'
         \ )
     endif
 endfunction

tests/rename_variable/js/only_on_current_scope_arrow_function.vader

@@ -0,0 +1,34 @@
+Given javascript:
+  function firstFunctionName() {
+      const someVariable
+  }
+
+  const currentFunctionName = () => {
+      const someVariable
+      someVariable
+  }
+
+  function thirdFunctionName() {
+      const someVariable
+  }
+
+Do:
+  /currentFunctionName\<Enter>
+  /someVariable\<Enter>
+  ;rv
+  New\<Enter>
+  \<Enter>
+
+Expect:
+  function firstFunctionName() {
+      const someVariable
+  }
+
+  const currentFunctionName = () => {
+      const someVariableNew
+      someVariableNew
+  }
+
+  function thirdFunctionName() {
+      const someVariable
+  }