Configurable Additional notes

[diorcety]

For French Factur-X, additional notes must be added to the xml (notably AAB, PMT, PMD). We should add a way to make it configurable.

(cf https://www.impots.gouv.fr/sites/default/files/media/1_metier/2_professionnel/EV/2_gestion/290_facturation_electronique/specification_externes_b2b/afnor/norme-afnor-factures.pdf page 24)

[diorcety]

Additional note codes are in: https://www.xrepository.de/api/xrepository/urn:xoev-de:kosit:codeliste:untdid.4451_1:technischerBestandteilGenericode

Should Erpnext support multiple "terms-and-conditions" on invoice?

[0xD0M1M0]

@diorcety is this related to #153 ?

[diorcety]

@diorcety is this related to #153 ?

Yes notably. But the other issue that you can have multiple terms in one invoice:

• AAI | General information -> Current Terms and Conditions
• PMT| Payment information -> Mandatory in French invoice
• PMD | Payment detail/remittance information -> Mandatory in French invoice

Here an example:
https://marketplace.canva.com/EAGAPp_VNwU/2/0/1131w/canva-facture-entreprise-minimaliste-%C3%A9l%C3%A9gant-blanc-noir-bleu-0f8njI3IU3c.jpg

On the left lower side you have in order:

• PMD and PMT in the same sentence
• AAI

I have made one draft commit

diorcety@8d16499

Based on the modification of the erpnext:
https://github.com/diorcety/erpnext/tree/multi_terms (cf frappe/erpnext#52622)

[barredterra]

@diorcety General terms and conditions as well as delivery terms are added here:

eu_einvoice/eu_einvoice/european_e_invoice/custom/sales_invoice.py

Lines 254 to 262 in 51ef083

	if self.invoice.terms:
	note = IncludedNote(subject_code="ABC") # Conditions of sale or purchase
	note.content.add(to_markdown(self.invoice.terms).strip())
	self.doc.header.notes.add(note)
	if self.invoice.incoterm:
	note = IncludedNote(subject_code="AAR") # Terms of delivery
	note.content.add(f"{self.invoice.incoterm} {self.invoice.named_place or ''}".strip())
	self.doc.header.notes.add(note)

Payment terms and payment means here:

eu_einvoice/eu_einvoice/european_e_invoice/custom/sales_invoice.py

Lines 629 to 689 in 51ef083

	def _add_payment_terms(self):
	for ps in self.invoice.payment_schedule:
	payment_terms = PaymentTerms()
	ps_description = ps.description or ""
	if ps.due_date:
	payment_terms.due = getdate(ps.due_date)
	if len(self.invoice.payment_schedule) > 1:
	payment_terms.partial_amount.add(
	(ps.payment_amount, None)
	) # [CII-DT-031] - currencyID should not be present
	if ps.discount and ps.discount_date:
	if self.profile == EInvoiceProfile.EXTENDED:
	payment_terms.discount_terms.basis_date_time = getdate(ps.discount_date)
	payment_terms.discount_terms.basis_amount = ps.payment_amount
	if ps.discount_type == "Percentage":
	payment_terms.discount_terms.calculation_percent = ps.discount
	elif ps.discount_type == "Amount":
	payment_terms.discount_terms.actual_amount = ps.discount
	elif self.profile == EInvoiceProfile.XRECHNUNG:
	ps_description = ps_description.replace(
	"#", "//"
	) # the character "#" is not allowed in the free text
	if ps.discount_type == "Percentage":
	discount_days = date_diff(ps.discount_date, self.invoice.posting_date)
	if discount_days < 0:
	basis_amount = (
	ps.payment_amount
	if round(ps.payment_amount, 2) != round(self.invoice.outstanding_amount, 2)
	else None
	)
	if ps_description:
	ps_description += "\n"
	ps_description += get_skonto_line(discount_days, ps.discount, basis_amount)
	ps_description += "\n"
	if ps_description:
	payment_terms.description = ps_description
	self.doc.trade.settlement.terms.add(payment_terms)
	def _add_payment_means(self):
	self.doc.trade.settlement.payment_means.type_code = payment_means_codes.get(
	[("Payment Terms Template", self.invoice.payment_terms_template)]
	+ [("Mode of Payment", term.mode_of_payment) for term in self.invoice.payment_schedule]
	)
	modes_of_payment = {ps.mode_of_payment for ps in self.invoice.payment_schedule if ps.mode_of_payment}
	for mode_of_payment in modes_of_payment:
	iban, bic = get_bank_details(mode_of_payment, self.invoice.company)
	if not iban:
	continue
	self.doc.trade.settlement.payment_means.payee_account.iban = iban
	if self.profile >= EInvoiceProfile.EN16931:
	self.doc.trade.settlement.payment_means.payee_account.account_name = self.invoice.company
	self.doc.trade.settlement.payment_means.payee_institution.bic = bic
	break

If you want to add your custom terms, you can do so via these dedicated hooks:

eu_einvoice/README.md

Lines 330 to 375 in 51ef083

	## Add your custom logic
	This app provides hooks to add custom logic to the eInvoice creation process:
	- `before_einvoice_generation`
	Called right before the eInvoice is generated. The hook function receives the **Sales Invoice** as an argument and can modify it.
	- `after_einvoice_generation`
	Called right after the eInvoice is generated. The hook function receives the **Sales Invoice** and the generated eInvoice as arguments.
	For example, your `myapp/hooks.py` could look like this:
	```python
	doc_events = {
	"Sales Invoice": {
	"before_einvoice_generation": "myapp.einvoice.before_einvoice_generation",
	"after_einvoice_generation": "myapp.einvoice.after_einvoice_generation",
	}
	}
	```
	And your `myapp/einvoice.py` like this:
	```python
	from typing import TYPE_CHECKING
	if TYPE_CHECKING:
	from drafthorse.models.document import Document
	from erpnext.accounts.doctype.sales_invoice.sales_invoice import SalesInvoice
	def before_einvoice_generation(doc: "SalesInvoice", event: str):
	"""Modify the Sales Invoice object before generating the eInvoice."""
	doc.customer_name = "Special Customer Name"
	def after_einvoice_generation(doc: "SalesInvoice", event: str, einvoice: "Document"):
	"""Modify the generated eInvoice after it was created."""
	einvoice.trade.agreement.buyer.name = doc.customer_name
	```
	> [!WARNING]
	> These methods are also triggered during the `validate` event of the **Sales Invoice**. In this case, if you change the Sales Invoice object, these changes will be saved to the database.