Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project will maintain continue #22

Open
tinymahua opened this issue Aug 3, 2023 · 4 comments
Open

Is this project will maintain continue #22

tinymahua opened this issue Aug 3, 2023 · 4 comments
Labels

Comments

@tinymahua
Copy link

No description provided.

@amalfra
Copy link
Owner

amalfra commented Aug 3, 2023

Yes, this will be maintained.

@tinymahua
Copy link
Author

I see the last commit time is 2022 year, so I asked this.

Recently I found 2 problem when I test this repo and pip package.

  1. After [pip install ], it create [src] directory in site-packages, src is a no meaning name, import it use import src is not fit.
  2. Modules import in source file are relative mode, I does not think this is a good way.

Base above, i asked it.
Fix them need change it's package structure and relative mode.
I hope I can join and maintain it. Can you accept this change about package structure and some what.

Yes, this will be maintained.

@amalfra
Copy link
Owner

amalfra commented Aug 13, 2023

@tinymahua https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/ is a description of src layouts. It's a standard layout and since we don't want code to be used src layout works best.

@tinymahua
Copy link
Author

@tinymahua https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/ is a description of src layouts. It's a standard layout and since we don't want code to be used src layout works best.

I agreen src layouts. I mean that it need a main package named docker_hub in src directory. And then set the setup.py target the installed packages.

Now code structure will happen a problem after pip install:
In my project, I use docker_hub need do:

from src.libs.xxx import yyy

Normal import statements should above:

from docker_hub.xxxx import yyy

Perhaps I desc not enough before, after a few time, I commit a PR, hope think it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants