fix(skills): validate every clause of a compound version range

The parse-time gate probed a range with `matches("0.0.0", spec)`, and `matches`
is `all()` over a generator — it short-circuits on the first clause the probe
version fails. Any real lower bound fails against `0.0.0`, so in
`">=1.2.0, 1.2.x"` the unreadable second clause was never parsed and the
manifest was accepted.

That reintroduced the machine-dependent verdict the gate exists to remove: the
bad clause then surfaced at load only where the skill was installed at a version
passing clause one, and elsewhere was misreported as an ordinary "does not
satisfy the pin". `RemoteSkill.resolve` had the same hole.

Walk the clauses directly instead of probing through `matches`, leaving match
semantics untouched everywhere else.

Also corrects the `version`/`required` rows of the skill-format field table,
which still described a pin as recorded-not-resolved twenty lines above the note
saying it is enforced, and asserts the skip reason in the optional-violation
test rather than only that the skill was skipped.

Author: Ovtcharov

docs/plans/skill-format.mdx

@@ -195,8 +195,8 @@ Each entry in `skills` or a set's list is either a **skill name** or a mapping:
 | Key | Type | Required | Description |
 |---|---|---|---|
 | `name` | string | yes | A skill name per [naming](#naming). |
-| `version` | string | no | SemVer or range. **Recorded, not resolved** in this phase — see below. |
-| `required` | bool | no | Default `true`. A missing `required: false` skill is logged and skipped; a missing required one fails the launch. |
+| `version` | string | no | SemVer or range, **enforced at load** against the installed skill's version — see below. |
+| `required` | bool | no | Default `true`. A `required: false` skill that is missing *or version-incompatible* is logged and skipped; either failure on a required one fails the launch. |
 
 **Set names** use the same slug shape as skill names, capped at 32 chars — a
 lowercase alphanumeric start and end with internal hyphens:

src/gaia/skills/versions.py

@@ -158,7 +158,15 @@ def validate_spec(spec: Optional[str]) -> None:
     Raises:
         SkillValidationError: naming the clause that could not be read.
     """
-    matches("0.0.0", spec)
+    # Every clause, deliberately not via ``matches``: its ``all()`` short-circuits
+    # on the first clause a probe version fails, which would leave a later
+    # unreadable clause of a conjunction unchecked.
+    normalized = (spec or "").strip()
+    if normalized.lower() in ANY_SPECS:
+        return
+    for clause in normalized.split(","):
+        if clause.strip():
+            _matches_clause("0.0.0", clause)
 
 
 def highest(versions: Iterable[str]) -> Optional[str]:

tests/unit/test_skill_sets.py

@@ -12,6 +12,7 @@
 
 from __future__ import annotations
 
+import logging
 from pathlib import Path
 from unittest.mock import MagicMock, patch
 
@@ -604,16 +605,26 @@ def test_agent_required_pin_violation_fails_the_launch(tmp_path, pinned):
     assert agent.active_skill_set is None
 
 
-def test_agent_optional_pin_violation_is_skipped_with_a_reason(tmp_path, pinned):
+def test_agent_optional_pin_violation_is_skipped_with_a_reason(
+    tmp_path, pinned, caplog
+):
     agent = _pinned_agent(
         tmp_path,
         pinned,
         {"name": "inbox-triage", "version": ">=2.0.0", "required": False},
     )
 
-    assert agent.load_skill_set() == {}
+    with caplog.at_level(logging.INFO):
+        assert agent.load_skill_set() == {}
     assert agent.active_skill_set == "work"
 
+    # "Skipped" has to be visible, not invisible: the reason names the pin and
+    # the version on disk, or the agent quietly runs without the capability.
+    skipped = "\n".join(
+        r.getMessage() for r in caplog.records if "inbox-triage" in r.getMessage()
+    )
+    assert ">=2.0.0" in skipped and "1.4.0" in skipped
+
 
 def test_agent_pin_against_an_unversioned_skill_is_refused(tmp_path, pinned):
     """Unsatisfiable by unknowability: absence of a version is not a match."""

tests/unit/test_skills_marketplace.py

@@ -143,10 +143,36 @@ def test_validate_spec_accepts_every_supported_range_shape():
         "~=1.2",
         "!=1.0.0",
         ">=1.2.0, <2.0.0",
+        ">=1.2.3-beta.1, <2.0.0",
+        ">= 1.0.0 , < 2.0.0",  # whitespace around the conjunction
     ):
         validate_spec(spec)
 
 
+@pytest.mark.parametrize(
+    "spec",
+    [
+        ">=1.2.0, 1.2.x",
+        ">=1.2.0, >=v2",
+        ">=1.2.0, <2.0.0.0",
+        "<2.0.0, junk",
+    ],
+)
+def test_validate_spec_checks_every_clause_of_a_conjunction(spec):
+    """The gate must not stop at the first clause a probe version fails.
+
+    ``matches`` is ``all()`` over a generator, so it short-circuits: probing
+    with a sentinel meant `>=1.2.0` returned False and the unreadable clause
+    after it was never parsed. The manifest was then accepted, and the failure
+    resurfaced at load only on machines with that skill installed at a version
+    passing clause one — the machine-dependent verdict this gate exists to kill.
+    """
+    from gaia.skills.versions import validate_spec
+
+    with pytest.raises(SkillValidationError, match="does not name a version number"):
+        validate_spec(spec)
+
+
 # ---------------------------------------------------------------------------
 # Tiers
 # ---------------------------------------------------------------------------