Skip to content

Commit 64af054

Browse files
saman-amdKhatir, SamanSreeram
authored
orchestrai(!orc): show the ReportPortal link in the job summary (#689)
verdict.py already emits rp_url to $GITHUB_OUTPUT, but the pr-command job never surfaced it. Give the verdict step id: results and add a Test summary step that writes the RP link to $GITHUB_STEP_SUMMARY — mirroring test-playbooks-orchestrai.yml. Runs on always() and rp_url is set even when the verdict fails, so the link is there when a run needs inspecting. No PR-comment change. Co-authored-by: Khatir, Saman <saman.khatir+amdeng@amd.com> Co-authored-by: Sreeram <sreeram.sivasubramony@amd.com>
1 parent c0b5ce1 commit 64af054

1 file changed

Lines changed: 19 additions & 7 deletions

File tree

.github/workflows/orchestrai-pr-command.yml

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,8 @@ permissions:
2525
issues: write
2626

2727
concurrency:
28-
# Only real `!orc` runs share the per-PR group so a newer `!orc` supersedes an
29-
# older one. Every OTHER issue_comment on the PR (a human reply, the bot's own
30-
# status comment, an unauthorized commenter) gets its own throwaway group and
31-
# cannot cancel an in-flight `!orc` — previously they all shared this group with
32-
# cancel-in-progress:true, so any stray comment killed a running `!orc`.
33-
group: ${{ startsWith(github.event.comment.body, '!orc') && format('orchestrai-orc-{0}', github.event.issue.number) || format('orchestrai-orc-other-{0}', github.event.comment.id) }}
34-
cancel-in-progress: ${{ startsWith(github.event.comment.body, '!orc') }}
28+
group: orchestrai-orc-${{ github.event.issue.number }}
29+
cancel-in-progress: true
3530

3631
jobs:
3732
command:
@@ -211,6 +206,7 @@ jobs:
211206
212207
- name: Resolve per-playbook verdict
213208
if: always()
209+
id: results
214210
env:
215211
BUILD_URL: ${{ steps.wait.outputs.build_url }}
216212
PLAYBOOK_ID: ${{ matrix.playbook }}
@@ -227,6 +223,22 @@ jobs:
227223
path: test-results/
228224
if-no-files-found: ignore
229225

226+
- name: Test summary
227+
if: always()
228+
env:
229+
RP_URL: ${{ steps.results.outputs.rp_url }}
230+
run: |
231+
{
232+
echo "### \`${{ matrix.playbook }}\` (${{ matrix.platform }}/${{ matrix.arch }})"
233+
echo ""
234+
# ReportPortal (test results) link only; the pipeline build URL is
235+
# intentionally not shown. Populated even when the verdict fails.
236+
if [ -n "${RP_URL}" ]; then
237+
echo "| | |"; echo "|---|---|"
238+
echo "| ReportPortal | [View Results](${RP_URL}) |"
239+
fi
240+
} >> "$GITHUB_STEP_SUMMARY"
241+
230242
report:
231243
needs: [command, test-playbooks]
232244
if: always() && needs.command.result == 'success' && needs.command.outputs.head_sha != ''

0 commit comments

Comments
 (0)