Duplicate Hostname in Email subject and body in Check/Task Failed messages

[nescafe2002]

Server Info (please complete the following information):

• RMM Version (as shown in top left of web UI): 0.19.2

Installation Method:

• Docker

Agent Info (please complete the following information):

• Agent version (as shown in the 'Summary' tab of the agent from web UI): 2.7.0

Describe the bug
Email subject and body contain hostname twice:
Client, Site, Hostname - Hostname - [Policy Name ] - [Check Name] Failed (- [More info])

Additional context
Note that the hostname is included in the (failed) templates and the __str__ methods.

For Checks:

tacticalrmm/api/tacticalrmm/checks/models.py

Line 531 in c8d72dd

subject = f"{self.agent.client.name}, {self.agent.site.name}, {self.agent.hostname} - {self} Failed"

tacticalrmm/api/tacticalrmm/checks/models.py

Line 158 in c8d72dd

return f"{self.agent.hostname} - {self.readable_desc}"

For Tasks:

tacticalrmm/api/tacticalrmm/autotasks/models.py

Line 525 in c8d72dd

subject = f"{self.agent.client.name}, {self.agent.site.name}, {self.agent.hostname} - {self} Failed"

tacticalrmm/api/tacticalrmm/autotasks/models.py

Line 541 in c8d72dd

subject = f"{self.agent.client.name}, {self.agent.site.name}, {self.agent.hostname} - {self} Failed"

tacticalrmm/api/tacticalrmm/autotasks/models.py

Line 497 in c8d72dd

return f"{self.agent.hostname} - {self.task}"

Possible solutions:

• Remove hostname from __str__ functions and add hostname to send_resolved_email functions
• Revert commits 6b9d775 and 4cae9cd

Also, note that the subject (Client, Site) is not included in the body of the Check resolved message:

tacticalrmm/api/tacticalrmm/checks/models.py

Line 656 in c8d72dd

body = f"{self} is now back to normal"

[SpookOz]

Hi team, I might be mistaken, but since this was implemented, it seems like the hostname no longer appears in the subject in the "Resolved" emails...

[SpookOz]

Note, this has been addressed in #2388