[ENG-2914] fix(salesforce): Batch WriteResult has either errors or data (unit-tests)

Author: Cobalt0s

providers/salesforce/batch-write_test.go

@@ -74,7 +74,7 @@ func TestBatchCreate(t *testing.T) { // nolint:funlen,gocognit,cyclop,maintidx
 						  "statusCode": "REQUIRED_FIELD_MISSING",
 						  "message": "Required fields are missing: [LastName]",
 						  "fields": ["LastName"]}`)},
-					Data: map[string]any{"referenceId": "ref0"},
+					Data: nil,
 				}, {
 					Success:  false,
 					RecordId: "",
@@ -126,7 +126,7 @@ func TestBatchCreate(t *testing.T) { // nolint:funlen,gocognit,cyclop,maintidx
 						  "message": "Duplicate ReferenceId found: ref1",
 						  "fields": []}`),
 					},
-					Data: map[string]any{"referenceId": "ref1"},
+					Data: nil,
 				}},
 				SuccessCount: 0,
 				FailureCount: 2,
@@ -272,33 +272,15 @@ func TestBatchUpdate(t *testing.T) { // nolint:funlen,gocognit,cyclop,maintidx
 							"statusCode": "MISSING_ARGUMENT",
 							"message": "Id not specified in an update call",
 							"fields": []}`)},
-					Data: map[string]any{
-						"success": false,
-						"errors": []any{
-							map[string]any{
-								"statusCode": "MISSING_ARGUMENT",
-								"message":    "Id not specified in an update call",
-								"fields":     []any{},
-							},
-						},
-					},
+					Data: nil,
 				}, {
 					Success:  false,
 					RecordId: "",
 					Errors: []any{mockutils.JSONErrorWrapper(`{
 							"statusCode": "MISSING_ARGUMENT",
 							"message": "Id not specified in an update call",
 							"fields": []}`)},
-					Data: map[string]any{
-						"success": false,
-						"errors": []any{
-							map[string]any{
-								"statusCode": "MISSING_ARGUMENT",
-								"message":    "Id not specified in an update call",
-								"fields":     []any{},
-							},
-						},
-					},
+					Data: nil,
 				}},
 				SuccessCount: 0,
 				FailureCount: 2,
@@ -337,16 +319,7 @@ func TestBatchUpdate(t *testing.T) { // nolint:funlen,gocognit,cyclop,maintidx
 							"statusCode": "MISSING_ARGUMENT",
 							"message": "Id not specified in an update call",
 							"fields": []}`)},
-					Data: map[string]any{
-						"success": false,
-						"errors": []any{
-							map[string]any{
-								"statusCode": "MISSING_ARGUMENT",
-								"message":    "Id not specified in an update call",
-								"fields":     []any{},
-							},
-						},
-					},
+					Data: nil,
 				}},
 				SuccessCount: 1,
 				FailureCount: 1,

test/utils/mockutils/writeResult.go

@@ -13,10 +13,16 @@ type writeResultComparator struct{}
 // SubsetData checks that expected WriteResult.Data is a subset of actual WriteResult.Data
 // other fields are strictly compared.
 func (writeResultComparator) SubsetData(actual, expected *common.WriteResult) bool {
+	// We are expecting more fields than there in the existence.
 	if len(actual.Data) < len(expected.Data) {
 		return false
 	}
 
+	// At least one field should be mentioned.
+	if len(actual.Data) > 0 && len(expected.Data) == 0 {
+		return false
+	}
+
 	for k, expectedValue := range expected.Data {
 		actualValue, ok := actual.Data[k]
 		if !ok {