Skip to content

Commit 2ec1731

Browse files
committed
Merge remote-tracking branch 'origin/amqplib-modernisation-1'
2 parents c94254c + 0602e15 commit 2ec1731

File tree

7 files changed

+43
-44
lines changed

7 files changed

+43
-44
lines changed

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515

1616
strategy:
1717
matrix:
18-
node-version: [10.x, 12.x, 14.x, 16.x, 18.x, 20.x]
18+
node-version: [18.x, 20.x, 22.x, 24.x]
1919
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
2020

2121
steps:

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020

2121
strategy:
2222
matrix:
23-
node-version: [10.x, 12.x, 14.x, 16.x, 18.x, 20.x]
23+
node-version: [18.x, 20.x, 22.x, 24.x]
2424
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
2525

2626
steps:

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Change log for amqplib
22

33
## v1.0.0
4-
- **BREAKING**: Update minimum Node.js requirement to v16
4+
- **BREAKING**: Update minimum Node.js requirement to v18
55
- Introduce Biome formatter for consistent code formatting
66
- Add automated formatting via pre-commit hooks using Lefthook
77
- Format entire codebase with standardised formatting rules

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ RABBITMQ_SRC_VERSION=v3.12.13
22
JSON=amqp-rabbitmq-0.9.1.json
33
AMQP_JSON=https://raw.githubusercontent.com/rabbitmq/rabbitmq-server/$(RABBITMQ_SRC_VERSION)/deps/rabbitmq_codegen/$(JSON)
44

5-
NODEJS_VERSIONS='10.21' '11.15' '12.18' '13.14' '14.5' '15.8' '16.3.0' '18.1.0' '20.10.0' '22.14.0'
5+
NODEJS_VERSIONS='18.1.0' '20.10.0' '22.14.0' '24.7.0'
66

77
MOCHA=./node_modules/.bin/mocha
88
_MOCHA=./node_modules/.bin/_mocha

biome.json

Lines changed: 36 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,42 @@
99
"attributePosition": "auto"
1010
},
1111
"linter": {
12-
"enabled": false
12+
"enabled": true,
13+
"rules": {
14+
"complexity": {
15+
"noCommaOperator": "off",
16+
"noUselessCatch": "off",
17+
"useArrowFunction": "off",
18+
"useOptionalChain": "off",
19+
"noArguments": "off",
20+
"useLiteralKeys": "off"
21+
},
22+
"correctness": {
23+
"noUnusedFunctionParameters": "off",
24+
"noUnusedVariables": "off",
25+
"noInnerDeclarations": "off",
26+
"useParseIntRadix": "off",
27+
"noSwitchDeclarations": "off",
28+
"noInvalidUseBeforeDeclaration": "off",
29+
"noPrecisionLoss": "off"
30+
},
31+
"style": {
32+
"useConst": "off",
33+
"useNodejsImportProtocol": "off",
34+
"useTemplate": "off",
35+
"useExponentiationOperator": "off"
36+
},
37+
"suspicious": {
38+
"noRedundantUseStrict": "off",
39+
"noAssignInExpressions": "off",
40+
"noAsyncPromiseExecutor": "off",
41+
"noDoubleEquals": "off",
42+
"noGlobalIsNan": "off",
43+
"noRedeclare": "off",
44+
"noGlobalIsFinite": "off",
45+
"noPrototypeBuiltins": "off"
46+
}
47+
}
1348
},
1449
"javascript": {
1550
"formatter": {

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"url": "git+https://github.com/amqp-node/amqplib.git"
1010
},
1111
"engines": {
12-
"node": ">=16"
12+
"node": ">=18"
1313
},
1414
"dependencies": {
1515
"buffer-more-ints": "~1.0.0",
@@ -25,7 +25,8 @@
2525
},
2626
"scripts": {
2727
"test": "make test",
28-
"format": "biome format . --write"
28+
"format": "biome format . --write",
29+
"lint": "biome lint ."
2930
},
3031
"keywords": [
3132
"AMQP",

todo.md

Lines changed: 0 additions & 37 deletions
This file was deleted.

0 commit comments

Comments
 (0)