Amqplib modernisation 2 #799
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documents comprehensive plan for introducing Biome formatter with: - Node.js v16 engine requirement update - Biome installation and configuration - Staged formatting rollout (lib/ first, then all files) - Test suite validation at each stage - Lefthook pre-commit hooks for automated formatting 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Update Node.js engine requirement from >=10 to >=16 - Add @biomejs/biome as development dependency with strict formatting rules - Configure Biome with 2-space indents, 140-char lines, single quotes, trailing commas - Install Lefthook for automated pre-commit formatting hooks - Add npm format script for manual code formatting - Format entire codebase (63 files) with consistent styling - Update changelog for v1.0.0 major release - All tests pass with formatted code 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove empty comment lines (//) from file headers - Remove unnecessary blank lines at top of files - Maintain 'use strict' directives consistently - Preserve meaningful comments and documentation - Clean up 12 files in lib/ directory for better readability All tests continue to pass after cleanup. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove 'use strict'; from all 13 JavaScript files in lib/ directory - Clean up formatting and extra blank lines after removal - Modern JavaScript environments default to strict mode - All tests continue to pass without strict mode directives 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Enable linter in biome.json configuration - Add npm run lint script to package.json - Biome linting now active with default rules (no custom rules configured) - Found 541 errors and 824 warnings across codebase for future cleanup - Linting covers all JavaScript files in project 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Disable all currently failing lint rules to establish clean baseline - Added 20 rule overrides across complexity, correctness, style, and suspicious categories - Biome linting now passes cleanly with no errors or warnings - Rules can be gradually re-enabled in future for incremental code improvements Disabled rules: - complexity: noCommaOperator, noUselessCatch, useArrowFunction, useLiteralKeys, useOptionalChain, noArguments - correctness: noUnusedFunctionParameters, noUnusedVariables, noInnerDeclarations, useParseIntRadix, noSwitchDeclarations, noInvalidUseBeforeDeclaration, noPrecisionLoss - style: useNodejsImportProtocol, useConst, useTemplate, useExponentiationOperator - suspicious: noGlobalIsNan, noRedundantUseStrict, noAssignInExpressions, noAsyncPromiseExecutor, noDoubleEquals, noRedeclare, noGlobalIsFinite, noPrototypeBuiltins 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add entries for source file header cleanup - Document removal of obsolete 'use strict' directives - Note addition of Biome linting with baseline configuration - All changes included in v1.0.0 modernisation release 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Collaborator
Author
|
Closing. biome made more changes than I intended |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing for applying biome linting