-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/re add typechecker #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
18a5a98 to
c2bee84
Compare
d170f3a to
ba0b0df
Compare
Coverage Report (Python 3.10)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Coverage Report (Python 3.13)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Coverage Report (Python 3.12)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
0e4eb3c to
d9321c4
Compare
|
had to launch tests manually though (no code change) https://github.com/anam-org/metaxy/actions/runs/18977281412 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR re-enables the previously commented-out typecheck job in the QA workflow and adds permission controls. The main changes modernize the typecheck job by replacing the Node.js binary workaround with environment variable save/restore operations.
- Re-enables the
typecheckjob that runs Basedpyright type checking - Replaces Node.js binary replacement logic with environment save/restore steps
- Adds explicit
contents: readpermission to thecheckjob
Comments suppressed due to low confidence (1)
.github/workflows/QA.yml:203
- The
checkjob'sneedslist is missingtypecheck. Since the typecheck job has been re-enabled, it should be added to the needs list to ensure the job is included in the final status check.
needs:
- test
- lint
- format
- docs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b520221 to
5e19916
Compare
.github/workflows/QA.yml
Outdated
| #- uses: nicknovitski/nix-develop@v1 | ||
| - name: Run Typecheck in Nix Shell | ||
| run: | | ||
| nix develop '.#python3.10' -c bash <<'EOF' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run nix develop '.#python3.10' -c bash <<'EOF'
nix: symbol lookup error: /nix/store/qhw0sp183mqd04x5jp75981kwya64npv-glibc-2.40-66/lib/libc.so.6: undefined symbol: __tunable_is_initialized, version GLIBC_PRIVATE
now using a temporary nix shell - still failing
a36d77e to
a2498cc
Compare
No description provided.