fixup! defining a wrapper connection handler with the objective of being generic

andreagilardoni · andreagilardoni · commit d47842b448aa · 2024-09-26T17:22:59.000+02:00
diff --git a/src/GenericConnectionHandler.cpp b/src/GenericConnectionHandler.cpp
@@ -92,7 +92,7 @@ NetworkConnectionState GenericConnectionHandler::update_handleDisconnected() {
     return _ch != nullptr ? _ch->update_handleDisconnected() : NetworkConnectionState::INIT;
 }
 
-#if not defined(BOARD_HAS_LORA)
+#if not (defined(BOARD_HAS_LORA) or defined(BOARD_HAS_NOTECARD))
 unsigned long GenericConnectionHandler::getTime() { // FIXME _ch may be nullptr
     return _ch->getTime();
 }
@@ -104,4 +104,5 @@ Client & GenericConnectionHandler::getClient() { // FIXME _ch may be nullptr
 UDP & GenericConnectionHandler::getUDP() { // FIXME _ch may be nullptr
     return _ch->getUDP();
 }
-#endif
+
+#endif // not (defined(BOARD_HAS_LORA) or defined(BOARD_HAS_NOTECARD))

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ NetworkConnectionState GenericConnectionHandler::update_handleDisconnected() {`
`92`	`92`	`return _ch != nullptr ? _ch->update_handleDisconnected() : NetworkConnectionState::INIT;`
`93`	`93`	`}`
`94`	`94`
`95`		`-#if not defined(BOARD_HAS_LORA)`
	`95`	`+#if not (defined(BOARD_HAS_LORA) or defined(BOARD_HAS_NOTECARD))`
`96`	`96`	`unsigned long GenericConnectionHandler::getTime() { // FIXME _ch may be nullptr`
`97`	`97`	`return _ch->getTime();`
`98`	`98`	`}`
`@@ -104,4 +104,5 @@ Client & GenericConnectionHandler::getClient() { // FIXME _ch may be nullptr`
`104`	`104`	`UDP & GenericConnectionHandler::getUDP() { // FIXME _ch may be nullptr`
`105`	`105`	`return _ch->getUDP();`
`106`	`106`	`}`
`107`		`-#endif`
	`107`	`+`
	`108`	`+#endif // not (defined(BOARD_HAS_LORA) or defined(BOARD_HAS_NOTECARD))`