fixup! defining a wrapper connection handler with the objective of being generic

Author: andreagilardoni

src/GenericConnectionHandler.cpp

@@ -20,43 +20,43 @@
 #include "Arduino_ConnectionHandler.h"
 
 void GenericConnectionHandler::updateSetting(const models::NetworkSetting& s) {
-
+    // FIXME do not allocate a conn handler when update settings cannot work
     switch(s.type) {
-        // #if defined(BOARD_HAS_WIFI)
-        // case NetworkAdapter::WIFI:
-        //     _ch = new WiFiConnectionHandler();
-        //     break;
-        // #endif
+        #if defined(BOARD_HAS_WIFI)
+        case NetworkAdapter::WIFI:
+            _ch = new WiFiConnectionHandler();
+            break;
+        #endif
 
         #if defined(BOARD_HAS_ETHERNET)
         case NetworkAdapter::ETHERNET:
             _ch = new EthernetConnectionHandler();
             break;
         #endif
 
-        // #if defined(BOARD_HAS_NB)
-        // case NetworkAdapter::NB:
-        //     _ch = new NBConnectionHandler();
-        //     break;
-        // #endif
+        #if defined(BOARD_HAS_NB)
+        case NetworkAdapter::NB:
+            _ch = new NBConnectionHandler();
+            break;
+        #endif
 
-        // #if defined(BOARD_HAS_GSM)
-        // case NetworkAdapter::GSM:
-        //     _ch = new GSMConnectionHandler();
-        //     break;
-        // #endif
+        #if defined(BOARD_HAS_GSM)
+        case NetworkAdapter::GSM:
+            _ch = new GSMConnectionHandler();
+            break;
+        #endif
 
-        // #if defined(BOARD_HAS_CATM1_NBIOT)
-        // case NetworkAdapter::CATM1:
-        //     _ch = new CatM1ConnectionHandler();
-        //     break;
-        // #endif
+        #if defined(BOARD_HAS_CATM1_NBIOT)
+        case NetworkAdapter::CATM1:
+            _ch = new CatM1ConnectionHandler();
+            break;
+        #endif
 
-        // #if defined(BOARD_HAS_CELLULAR)
-        // case NetworkAdapter::CELL:
-        //     _ch = new CellularConnectionHandler();
-        //     break;
-        // #endif
+        #if defined(BOARD_HAS_CELLULAR)
+        case NetworkAdapter::CELL:
+            _ch = new CellularConnectionHandler();
+            break;
+        #endif
 
         // #if defined(BOARD_HAS_NOTECARD) // FIXME understand how to adapt it to the settings structure
         // case NOTECARD:

src/GenericConnectionHandler.h

@@ -15,8 +15,8 @@
    a commercial license, send an email to [email protected].
 */
 
-#ifndef ARDUINO_WIFI_CONNECTION_HANDLER_H_
-#define ARDUINO_WIFI_CONNECTION_HANDLER_H_
+#ifndef ARDUINO_GENERIC_CONNECTION_HANDLER_H_
+#define ARDUINO_GENERIC_CONNECTION_HANDLER_H_
 
 /******************************************************************************
    INCLUDE
@@ -57,4 +57,4 @@ class GenericConnectionHandler : public ConnectionHandler
     ConnectionHandler* _ch;
 };
 
-#endif /* ARDUINO_WIFI_CONNECTION_HANDLER_H_ */
+#endif /* ARDUINO_GENERIC_CONNECTION_HANDLER_H_ */