Skip to content

Commit 4846811

Browse files
committed
extract private methods to trait
1 parent 04f372f commit 4846811

File tree

2 files changed

+40
-31
lines changed

2 files changed

+40
-31
lines changed

tests/Feature/ExportPostmanTest.php

+3-31
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,12 @@
55
use AndreasElia\PostmanGenerator\Tests\TestCase;
66
use Illuminate\Support\Arr;
77
use Illuminate\Support\Facades\Storage;
8+
use AndreasElia\PostmanGenerator\Tests\Fixtures\CollectionHelpersTrait;
89

910
class ExportPostmanTest extends TestCase
1011
{
12+
use CollectionHelpersTrait;
13+
1114
protected function setUp(): void
1215
{
1316
parent::setUp();
@@ -386,35 +389,4 @@ public static function providerFormDataEnabled(): array
386389
],
387390
];
388391
}
389-
390-
private function countCollectionItems(array $collectionItems)
391-
{
392-
$sum = 0;
393-
394-
foreach ($collectionItems as $item) {
395-
$sum += $this->retrieveRoutes($item);
396-
}
397-
398-
return $sum;
399-
}
400-
401-
private function retrieveRoutes(array $route)
402-
{
403-
// Skip patch routes
404-
if (isset($route['request']['method']) && $route['request']['method'] === 'PATCH') {
405-
return 0;
406-
}
407-
408-
if (isset($route['item'])) {
409-
$sum = 0;
410-
411-
foreach ($route['item'] as $item) {
412-
$sum += $this->retrieveRoutes($item);
413-
}
414-
415-
return $sum;
416-
}
417-
418-
return 1;
419-
}
420392
}
+37
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
<?php
2+
3+
namespace AndreasElia\PostmanGenerator\Tests\Fixtures;
4+
5+
trait CollectionHelpersTrait
6+
{
7+
private function retrieveRoutes(array $route)
8+
{
9+
// Skip patch routes
10+
if (isset($route['request']['method']) && $route['request']['method'] === 'PATCH') {
11+
return 0;
12+
}
13+
14+
if (isset($route['item'])) {
15+
$sum = 0;
16+
17+
foreach ($route['item'] as $item) {
18+
$sum += $this->retrieveRoutes($item);
19+
}
20+
21+
return $sum;
22+
}
23+
24+
return 1;
25+
}
26+
27+
private function countCollectionItems(array $collectionItems)
28+
{
29+
$sum = 0;
30+
31+
foreach ($collectionItems as $item) {
32+
$sum += $this->retrieveRoutes($item);
33+
}
34+
35+
return $sum;
36+
}
37+
}

0 commit comments

Comments
 (0)