-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project file in /home/ #392
Comments
Thanks for filing this bug. You read my mind somehow. Yes, climbing is not the ideal behaviour, I will change it. |
But what about the default config file location like |
@1kyu this is an interesting idea, but it's not related to this bug. I created a separate issue: #417 |
🎉 This issue has been resolved in version 0.30.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Any nitpick ROOT_FILES/PROJECT_FILES within the parent directory cause the app to use this as the project directory and thus config files are created in the wrong location.
I had a pipfile in my home directory that was causing the issue.
2021-07-16 11:40:28.389 | DEBUG | nitpick.project:find_root:81 - Project files seen: {PosixPath('/home/me/Pipfile'), PosixPath('/home/me/Pipfile.lock')}
My project directory was then set to
/home/me
rather than the correct place and where nitpick was run from/home/me/project
Why do we climb the file tree? Why not just use the current dir and fail if nothing is found? Push it back to the user rather mainting the overhead of trying to "find" the root
The text was updated successfully, but these errors were encountered: