Skip to content

Commit 457b787

Browse files
committed
style (RMS): Use DErrno.cmpError and Request.delayNextExecution
1 parent 350317c commit 457b787

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/DIRAC/RequestManagementSystem/private/RequestTask.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333

3434
# # from DIRAC
3535
from DIRAC import gLogger, S_OK, S_ERROR, gConfig
36+
from DIRAC.Core.Utilities import DErrno
3637
from DIRAC.FrameworkSystem.Client.MonitoringClient import gMonitor
3738
from DIRAC.RequestManagementSystem.Client.ReqClient import ReqClient
3839
from DIRAC.RequestManagementSystem.Client.Request import Request
@@ -279,7 +280,8 @@ def __call__(self):
279280
if not setupProxy["OK"]:
280281
userSuspended = "User is currently suspended"
281282
self.request.Error = setupProxy["Message"]
282-
if 'has no proxy registered' in setupProxy["Message"]:
283+
# In case the user does not have proxy
284+
if DErrno.cmpError(setupProxy, DErrno.EPROXYFIND):
283285
self.log.error('Error setting proxy. Request set to Failed:', setupProxy["Message"])
284286
# If user is no longer registered, fail the request
285287
for operation in self.request:
@@ -288,7 +290,7 @@ def __call__(self):
288290
operation.Status = 'Failed'
289291
elif userSuspended in setupProxy['Message']:
290292
# If user is suspended, wait for a long time
291-
self.request.NotBefore = datetime.datetime.utcnow() + datetime.timedelta(hours=6)
293+
self.request.delayNextExecution(6 * 60)
292294
self.request.Error = userSuspended
293295
self.log.error("Error setting proxy: " + userSuspended, self.request.OwnerDN)
294296
else:

0 commit comments

Comments
 (0)