Fix the run_command utility function to rely on process return code rather than stderr to determine if compilation has finished successfully.

Fixes #83

Author: Andrey Fedoseev

CHANGES.rst

@@ -2,6 +2,14 @@
 Changes
 =======
 
+Dev
+===
+
+- Fix the ``run_command`` utility function to rely on process return code rather than stderr to determine if compilation
+  has finished successfully. WARNING! Changes in ``run_command`` are backward incompatible. If you use this function in
+  your custom compiler you should update your code.
+
+
 1.3.1
 =====
 

circle.yml

@@ -7,7 +7,7 @@ dependencies:
     - npm install -g [email protected]
     - npm install -g [email protected]
     - npm install -g [email protected]
-    - gem install sass -v 3.4.9
+    - gem install sass -v 3.4.22
     - gem install compass -v 1.0.1
     - pip install tox
     - pip install codecov

provision.sh

@@ -7,7 +7,7 @@
 sudo aptitude update
 sudo aptitude install -y virtualenvwrapper python-dev ruby-dev node npm sqlite3
 
-sudo gem install sass -v 3.4.9
+sudo gem install sass -v 3.4.22
 sudo gem install compass -v 1.0.1
 
 # Fix path to nodejs executable

static_precompiler/compilers/babel.py

@@ -57,8 +57,8 @@ def compile_file(self, source_path):
         args.extend(["-o", full_output_path])
         args.append(self.get_full_source_path(source_path))
 
-        out, errors = utils.run_command(args)
-        if errors:
+        return_code, out, errors = utils.run_command(args)
+        if return_code:
             raise exceptions.StaticCompilationError(errors)
 
         if self.is_sourcemap_enabled:
@@ -71,8 +71,8 @@ def compile_source(self, source):
             self.executable,
         ] + self.get_extra_args()
 
-        out, errors = utils.run_command(args, source)
-        if errors:
+        return_code, out, errors = utils.run_command(args, source)
+        if return_code:
             raise exceptions.StaticCompilationError(errors)
 
         return out

static_precompiler/compilers/coffeescript.py

@@ -32,9 +32,9 @@ def compile_file(self, source_path):
             "-o", os.path.dirname(full_output_path),
             self.get_full_source_path(source_path),
         ])
-        out, errors = utils.run_command(args)
+        return_code, out, errors = utils.run_command(args)
 
-        if errors:
+        if return_code:
             raise exceptions.StaticCompilationError(errors)
 
         if self.is_sourcemap_enabled:
@@ -49,8 +49,8 @@ def compile_source(self, source):
             "-s",
             "-p",
         ]
-        out, errors = utils.run_command(args, source)
-        if errors:
+        return_code, out, errors = utils.run_command(args, source)
+        if return_code:
             raise exceptions.StaticCompilationError(errors)
 
         return out

static_precompiler/compilers/handlebars.py

@@ -65,9 +65,9 @@ def compile_file(self, source_path):
         if self.is_sourcemap_enabled:
             args += ["--map", full_output_path + ".map"]
 
-        out, errors = utils.run_command(args)
+        return_code, out, errors = utils.run_command(args)
 
-        if errors:
+        if return_code:
             raise exceptions.StaticCompilationError(errors)
 
         if self.is_sourcemap_enabled:
@@ -81,8 +81,8 @@ def compile_source(self, source):
             "-i", "-",
         ] + self.get_extra_args()
 
-        out, errors = utils.run_command(args, source)
-        if errors:
+        return_code, out, errors = utils.run_command(args, source)
+        if return_code:
             raise exceptions.StaticCompilationError(errors)
 
         return out

static_precompiler/compilers/less.py

@@ -58,9 +58,9 @@ def compile_file(self, source_path):
             self.get_full_source_path(source_path),
             full_output_path,
         ])
-        out, errors = utils.run_command(args, cwd=cwd)
+        return_code, out, errors = utils.run_command(args, cwd=cwd)
 
-        if errors:
+        if return_code:
             raise exceptions.StaticCompilationError(errors)
 
         utils.convert_urls(full_output_path, source_path)
@@ -76,9 +76,9 @@ def compile_source(self, source):
             "-"
         ]
 
-        out, errors = utils.run_command(args, source)
+        return_code, out, errors = utils.run_command(args, source)
 
-        if errors:
+        if return_code:
             raise exceptions.StaticCompilationError(errors)
 
         return out

static_precompiler/compilers/livescript.py

@@ -36,9 +36,9 @@ def compile_file(self, source_path):
             "-o", os.path.dirname(full_output_path),
             self.get_full_source_path(source_path),
         ])
-        out, errors = utils.run_command(args)
+        return_code, out, errors = utils.run_command(args)
 
-        if errors:
+        if return_code:
             raise exceptions.StaticCompilationError(errors)
 
         if self.is_sourcemap_enabled:
@@ -53,8 +53,8 @@ def compile_source(self, source):
             "-s",
             "-p",
         ]
-        out, errors = utils.run_command(args, source)
-        if errors:
+        return_code, out, errors = utils.run_command(args, source)
+        if return_code:
             raise exceptions.StaticCompilationError(errors)
 
         return out

static_precompiler/compilers/scss.py

@@ -81,9 +81,9 @@ def compile_file(self, source_path):
         # `cwd` is a directory containing `source_path`.
         # Ex: source_path = '1/2/3', full_source_path = '/abc/1/2/3' -> cwd = '/abc'
         cwd = os.path.normpath(os.path.join(full_source_path, *([".."] * len(source_path.split("/")))))
-        out, errors = utils.run_command(args, None, cwd=cwd)
+        return_code, out, errors = utils.run_command(args, None, cwd=cwd)
 
-        if errors:
+        if return_code:
             if os.path.exists(full_output_path):
                 os.remove(full_output_path)
             raise exceptions.StaticCompilationError(errors)
@@ -104,8 +104,8 @@ def compile_source(self, source):
         if self.executable.endswith("sass"):
             args.append("--scss")
 
-        out, errors = utils.run_command(args, source)
-        if errors:
+        return_code, out, errors = utils.run_command(args, source)
+        if return_code:
             raise exceptions.StaticCompilationError(errors)
 
         return out
@@ -274,8 +274,8 @@ def compile_source(self, source):
         if self.executable.endswith("scss"):
             args.append("--sass")
 
-        out, errors = utils.run_command(args, source)
-        if errors:
+        return_code, out, errors = utils.run_command(args, source)
+        if return_code:
             raise exceptions.StaticCompilationError(errors)
 
         return out

static_precompiler/compilers/stylus.py

@@ -30,9 +30,9 @@ def compile_source(self, source):
             self.executable,
             "-p",
         ]
-        out, errors = utils.run_command(args, input=source)
+        return_code, out, errors = utils.run_command(args, input=source)
 
-        if errors:
+        if return_code:
             raise exceptions.StaticCompilationError(errors)
 
         return out
@@ -57,9 +57,9 @@ def compile_file(self, source_path):
         # `cwd` is a directory containing `source_path`.
         # Ex: source_path = '1/2/3', full_source_path = '/abc/1/2/3' -> cwd = '/abc'
         cwd = os.path.normpath(os.path.join(full_source_path, *([".."] * len(source_path.split("/")))))
-        out, errors = utils.run_command(args, cwd=cwd)
+        return_code, out, errors = utils.run_command(args, cwd=cwd)
 
-        if errors:
+        if return_code:
             raise exceptions.StaticCompilationError(errors)
 
         utils.convert_urls(full_output_path, source_path)