ViewModels are being reloaded on config changes

[kimlongkpop1]

"Branch : todo-mvvm-live"

. when i rotate device , viewmodel.start has call again and reload data from repo ,the method replaceData is call twice because it load fist time from cache list in viewmodel and second time from list in repo, so the viewmodel architecture are not applied at this time , please fix this , tkanks

[JoseAlcerreca]

You're right, this is a legacy from presenters. You can just start loading in the VM's constructor.

[jeffmcnd]

Would adding loading function calls in the constructor cause issues for testing? For example, we might have to provide mock classes that aren't relevant or spy the view model in order to test something else but methods are called in the constructor so we can't do anything about it.

Could we instead use the savedInstanceState variable to check to see if we should call loading methods? If the Bundle is null then we know to call load method(s) otherwise we don't need to call the load methods.

override fun onCreate(savedInstanceState: Bundle?) {
    // ...
    if (savedInstanceState == null) {
        viewModel.load()
    }
}