Skip to content
This repository was archived by the owner on Jul 11, 2025. It is now read-only.

Commit 27b28e3

Browse files
committed
fix some lint warnings
1 parent d38e307 commit 27b28e3

File tree

1 file changed

+22
-27
lines changed
  • SliceViewerKotlin/app/src/main/java/com/example/android/sliceviewer/util

1 file changed

+22
-27
lines changed

SliceViewerKotlin/app/src/main/java/com/example/android/sliceviewer/util/SliceViewKtx.kt

Lines changed: 22 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -30,62 +30,57 @@ import androidx.slice.core.SliceHints
3030
import androidx.slice.widget.SliceLiveData
3131
import androidx.slice.widget.SliceView
3232
import androidx.slice.widget.SliceView.OnSliceActionListener
33-
import com.example.android.sliceviewer.ui.list.SliceViewerActivity
3433
import com.example.android.sliceviewer.ui.list.SliceViewerActivity.Companion.TAG
3534

3635
fun SliceView.bind(
37-
context: Context,
38-
lifecycleOwner: LifecycleOwner,
39-
uri: Uri,
40-
onSliceActionListener: OnSliceActionListener = OnSliceActionListener { _, _ -> },
41-
onClickListener: OnClickListener = OnClickListener { },
42-
onLongClickListener: OnLongClickListener = OnLongClickListener { false },
43-
scrollable: Boolean = false
36+
context: Context,
37+
lifecycleOwner: LifecycleOwner,
38+
uri: Uri,
39+
onSliceActionListener: OnSliceActionListener = OnSliceActionListener { _, _ -> },
40+
onClickListener: OnClickListener = OnClickListener { },
41+
onLongClickListener: OnLongClickListener = OnLongClickListener { false },
42+
scrollable: Boolean = false
4443
) {
4544
setOnSliceActionListener(onSliceActionListener)
4645
setOnClickListener(onClickListener)
47-
setScrollable(scrollable)
46+
isScrollable = scrollable
4847
setOnLongClickListener(onLongClickListener)
4948
if (uri.scheme == null) {
5049
Log.w(TAG, "Scheme is null for URI $uri")
5150
return
5251
}
5352
// If someone accidentally prepends the "slice-" prefix to their scheme, let's remove it.
5453
val scheme =
55-
if (uri.scheme.startsWith("slice-")) {
56-
uri.scheme.replace("slice-", "")
57-
}
58-
else {
59-
uri.scheme
60-
}
54+
if (uri.scheme.startsWith("slice-")) {
55+
uri.scheme.replace("slice-", "")
56+
} else {
57+
uri.scheme
58+
}
6159
if (scheme == ContentResolver.SCHEME_CONTENT ||
62-
scheme.equals("https", true) ||
63-
scheme.equals("http", true)
60+
scheme.equals("https", true) ||
61+
scheme.equals("http", true)
6462
) {
6563
val intent = Intent(Intent.ACTION_VIEW, uri)
6664
val sliceLiveData = SliceLiveData.fromIntent(context, intent)
67-
sliceLiveData?.removeObservers(lifecycleOwner)
65+
sliceLiveData.removeObservers(lifecycleOwner)
6866
try {
69-
sliceLiveData?.observe(lifecycleOwner, Observer { updatedSlice ->
67+
sliceLiveData.observe(lifecycleOwner, Observer { updatedSlice ->
7068
if (updatedSlice == null) return@Observer
7169
slice = updatedSlice
7270
val expiry = SliceMetadata.from(context, updatedSlice).expiry
7371
if (expiry != SliceHints.INFINITY) {
7472
// Shows the updated text after the TTL expires.
7573
postDelayed(
76-
{ slice = updatedSlice },
77-
expiry - System.currentTimeMillis() + 15
74+
{ slice = updatedSlice },
75+
expiry - System.currentTimeMillis() + 15
7876
)
7977
}
80-
Log.d(SliceViewerActivity.TAG, "Update Slice: $updatedSlice")
78+
Log.d(TAG, "Update Slice: $updatedSlice")
8179
})
8280
} catch (e: Exception) {
83-
Log.e(
84-
SliceViewerActivity.TAG,
85-
"Failed to find a valid ContentProvider for authority: $uri"
86-
)
81+
Log.e(TAG, "Failed to find a valid ContentProvider for authority: $uri")
8782
}
8883
} else {
89-
Log.w(SliceViewerActivity.TAG, "Invalid uri, skipping slice: $uri")
84+
Log.w(TAG, "Invalid uri, skipping slice: $uri")
9085
}
9186
}

0 commit comments

Comments
 (0)