Open
Description
Use case description
Subtitle edge (text outline) is an important part of accessibility to make text readable. However the current implementation hardcodes this to twoDpInPx and on some devices like some TV screens, this might be very small and make text unreadable. There is currently no API surface nor internal method accessible via reflection to change the subtitle outline width.
Proposed solutions/Alternatives considered
- Allow for some sort of modification of this via CaptionStyleCompat. I know this might not be possible due to android.view.accessibility.CaptioningManager.CaptionStyle. But honestly, this restriction is makes no sense if I as an app developer want to deliver an specific experience.
- Change this to Sp. Why is it even in Dp to begin with? The android docs specifically calls Sp when text is involved. https://developer.android.com/training/multiscreen/screendensities
- Allow for cues to modify this so we can modify the text style in SubtitleParser.
- Allow for custom subtitle painters/subtitle views. Right now the subtitle view is directly set to R.id.exo_subtitles and is a final SubtitleView, meaning that there is no possible way to modify the subtitle rendering after parsing it.
- Insert a hidden reflection method/mark as non final. Even with reflection this property is currently impossible to modify as it is marked as private + final. Just adding a hidden method or marking this as non final would fix this. It is impossible to modify this one variable without forking the entire repository.
Note, this is a resubmission of google/ExoPlayer#10507 but exoplayer has been marked as deprecated.