Skip to content

Commit 60308d1

Browse files
christopherthielenmergify[bot]
authored andcommitted
chore(lint): remove tslint from the project
1 parent 07775e2 commit 60308d1

11 files changed

+30
-184
lines changed

.eslintrc.js

+14-14
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
1-
/*
2-
👋 Hi! This file was autogenerated by tslint-to-eslint-config.
3-
https://github.com/typescript-eslint/tslint-to-eslint-config
4-
5-
It represents the closest reasonable ESLint configuration to this
6-
project's original TSLint configuration.
7-
8-
We recommend eventually switching this configuration to extend from
9-
the recommended rulesets in typescript-eslint.
10-
https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/FAQs.md
11-
12-
Happy linting! 💖
13-
*/
1+
// eslint-disable-next-line no-undef
142
module.exports = {
153
env: { browser: true },
164
parser: '@typescript-eslint/parser',
175
plugins: ['@typescript-eslint'],
186
extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended', 'prettier', 'prettier/@typescript-eslint'],
19-
rules: {},
7+
rules: {
8+
'@typescript-eslint/no-explicit-any': 'off',
9+
'@typescript-eslint/explicit-module-boundary-types': 'off',
10+
11+
'@typescript-eslint/ban-types': [
12+
'error',
13+
{
14+
types: {
15+
Function: false,
16+
},
17+
},
18+
],
19+
},
2020
};

.npmignore

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ bower.json
1111
karma.conf.js
1212
tsconfig.json
1313
tsconfig.**.json
14-
tslint.json
1514
webpack.config.js
1615

1716
*.iml

package.json

+1-4
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@
8585
"@types/angular-mocks": "^1.7.0",
8686
"@types/jest": "^26.0.5",
8787
"@typescript-eslint/eslint-plugin": "^3.7.0",
88-
"@typescript-eslint/eslint-plugin-tslint": "^3.7.0",
8988
"@typescript-eslint/parser": "^3.7.0",
9089
"@uirouter/publish-scripts": "2.5.3",
9190
"angular": "1.8.0",
@@ -104,8 +103,6 @@
104103
"rollup-plugin-sourcemaps": "^0.6.2",
105104
"rollup-plugin-terser": "^6.1.0",
106105
"ts-jest": "^26.0.0",
107-
"tslint": "5.20.1",
108-
"tslint-eslint-rules": "^5.4.0",
109106
"typescript": "^3.9.7",
110107
"utf-8-validate": "5.0.2"
111108
},
@@ -134,7 +131,7 @@
134131
"Components": [
135132
"uiView",
136133
"UISref",
137-
"UISrefActive"
134+
"UISrefActive","uiStateDirective"
138135
],
139136
"Other": [
140137
"Transition",

src/angular.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/** @publicapi @module ng1 */ /** */
22
import * as ng_from_import from 'angular';
3-
/** @hidden */ declare var angular;
3+
/** @hidden */ declare let angular;
44
/** @hidden */ const ng_from_global = angular;
55
/** @hidden */ export const ng = ng_from_import && ng_from_import.module ? ng_from_import : ng_from_global;

src/directives/stateDirectives.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ import {
3434
import { UIViewData } from './viewDirective';
3535

3636
/** @hidden Used for typedoc */
37-
export interface ng1_directive {} // tslint:disable-line:class-name
37+
export interface ng1_directive {}
3838

3939
/** @hidden */
4040
function parseStateRef(ref: string) {
@@ -294,7 +294,6 @@ uiSrefDirective = [
294294
const type = getTypeInfo(element);
295295
const active = uiSrefActive[1] || uiSrefActive[0];
296296
let unlinkInfoFn: Function = null;
297-
let hookFn;
298297

299298
const rawDef = {} as Def;
300299
const getDef = () => processedDef($state, element, rawDef);
@@ -328,7 +327,7 @@ uiSrefDirective = [
328327
scope.$on('$destroy', <any>$uiRouter.transitionService.onSuccess({}, update));
329328

330329
if (!type.clickable) return;
331-
hookFn = clickHook(element, $state, $timeout, type, getDef);
330+
const hookFn = clickHook(element, $state, $timeout, type, getDef);
332331
bindEvents(element, scope, hookFn, rawDef.uiStateOpts);
333332
},
334333
};

src/injectables.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint-disable @typescript-eslint/no-unused-vars */
12
/**
23
* # Angular 1 injectable services
34
*
@@ -48,7 +49,6 @@
4849
*
4950
* @preferred @publicapi @module injectables
5051
*/ /** */
51-
/* tslint:disable:prefer-const */
5252
import { StateProvider } from './stateProvider';
5353
import {
5454
StateService,

src/interface.ts

-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ export interface Ng1StateTransitionHook {
5050
*
5151
* Used to reset [[StateDeclaration]] typings to `any` so the [[Ng1StateDeclaration]] interface can then narrow them */
5252
export interface _Ng1StateDeclaration extends StateDeclaration {
53-
// tslint:disable-line:class-name
5453
onExit?: any;
5554
onRetain?: any;
5655
onEnter?: any;

src/services.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -37,19 +37,18 @@ import { StateProvider } from './stateProvider';
3737
import { getStateHookBuilder } from './statebuilders/onEnterExitRetain';
3838
import { Ng1LocationServices } from './locationServices';
3939
import { UrlRouterProvider } from './urlRouterProvider';
40-
import IInjectorService = angular.auto.IInjectorService; // tslint:disable-line
40+
import IInjectorService = angular.auto.IInjectorService;
4141

4242
angular.module('ui.router.angular1', []);
4343
const mod_init = angular.module('ui.router.init', ['ng']);
4444
const mod_util = angular.module('ui.router.util', ['ui.router.init']);
4545
const mod_rtr = angular.module('ui.router.router', ['ui.router.util']);
4646
const mod_state = angular.module('ui.router.state', ['ui.router.router', 'ui.router.util', 'ui.router.angular1']);
4747
const mod_main = angular.module('ui.router', ['ui.router.init', 'ui.router.state', 'ui.router.angular1']);
48-
const mod_cmpt = angular.module('ui.router.compat', ['ui.router']); // tslint:disable-line
48+
const mod_cmpt = angular.module('ui.router.compat', ['ui.router']);
4949

5050
declare module '@uirouter/core/lib/router' {
5151
interface UIRouter {
52-
// tslint:disable-line:no-shadowed-variable
5352
/** @hidden */
5453
stateProvider: StateProvider;
5554
/** @hidden */

src/urlRouterProvider.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export interface RawNg1RuleFunction {
3131
* @deprecated
3232
*/
3333
export class UrlRouterProvider {
34-
static injectableHandler(router: UIRouter, handler): UrlRuleHandlerFn {
34+
static injectableHandler(router: UIRouter, handler: IInjectable): UrlRuleHandlerFn {
3535
return (match) => services.$injector.invoke(handler, null, { $match: match, $stateParams: router.globals.params });
3636
}
3737

@@ -164,7 +164,7 @@ export class UrlRouterProvider {
164164
*
165165
* Note: the handler may also invoke arbitrary code, such as `$state.go()`
166166
*/
167-
when(what: RegExp | UrlMatcher | string, handler: string | IInjectable) {
167+
when(what: RegExp | UrlMatcher | string, handler: string | IInjectable): this {
168168
if (isArray(handler) || isFunction(handler)) {
169169
handler = UrlRouterProvider.injectableHandler(this.router, handler);
170170
}
@@ -203,7 +203,7 @@ export class UrlRouterProvider {
203203
* @param defer Indicates whether to defer location change interception.
204204
* Passing no parameter is equivalent to `true`.
205205
*/
206-
deferIntercept(defer?: boolean) {
206+
deferIntercept(defer?: boolean): void {
207207
this.router.urlService.deferIntercept(defer);
208208
}
209209
}

tslint.json

-59
This file was deleted.

yarn.lock

+6-94
Original file line numberDiff line numberDiff line change
@@ -675,14 +675,6 @@
675675
dependencies:
676676
"@types/yargs-parser" "*"
677677

678-
"@typescript-eslint/eslint-plugin-tslint@^3.7.0":
679-
version "3.7.0"
680-
resolved "https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin-tslint/-/eslint-plugin-tslint-3.7.0.tgz#0fecad8bb831879f4caacca91c95f39aa54f8cba"
681-
integrity sha512-Ek43DU8KvvRMpfgO45R6mXTwfqO7Wx0iBTMj77JQRkVTLZPJXncjuJfc9+d8K/dN8HPG1w6K2KBnRQKqupztyA==
682-
dependencies:
683-
"@typescript-eslint/experimental-utils" "3.7.0"
684-
lodash "^4.17.15"
685-
686678
"@typescript-eslint/eslint-plugin@^3.7.0":
687679
version "3.7.0"
688680
resolved "https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-3.7.0.tgz#0f91aa3c83d019591719e597fbdb73a59595a263"
@@ -1190,11 +1182,6 @@ [email protected]:
11901182
dependencies:
11911183
node-gyp-build "~3.7.0"
11921184

1193-
builtin-modules@^1.1.1:
1194-
version "1.1.1"
1195-
resolved "https://registry.yarnpkg.com/builtin-modules/-/builtin-modules-1.1.1.tgz#270f076c5a72c02f5b65a47df94c5fe3a278892f"
1196-
integrity sha1-Jw8HbFpywC9bZaR9+Uxf46J4iS8=
1197-
11981185
builtin-modules@^3.1.0:
11991186
version "3.1.0"
12001187
resolved "https://registry.yarnpkg.com/builtin-modules/-/builtin-modules-3.1.0.tgz#aad97c15131eb76b65b50ef208e7584cd76a7484"
@@ -1292,7 +1279,7 @@ caseless@~0.12.0:
12921279
resolved "https://registry.yarnpkg.com/caseless/-/caseless-0.12.0.tgz#1b681c21ff84033c826543090689420d187151dc"
12931280
integrity sha1-G2gcIf+EAzyCZUMJBolCDRhxUdw=
12941281

1295-
chalk@^2.0.0, chalk@^2.1.0, chalk@^2.3.0, chalk@^2.4.1, chalk@^2.4.2:
1282+
chalk@^2.0.0, chalk@^2.1.0, chalk@^2.4.1, chalk@^2.4.2:
12961283
version "2.4.2"
12971284
resolved "https://registry.yarnpkg.com/chalk/-/chalk-2.4.2.tgz#cd42541677a54333cf541a49108c1432b44c9424"
12981285
integrity sha512-Mti+f9lpJNcwF4tWV8/OrTTtF1gZi+f8FqlyAdouralcFWFQWF2+NgCHShjkCb+IFBLq9buZwE1xckQU4peSuQ==
@@ -1424,16 +1411,16 @@ combined-stream@^1.0.6, combined-stream@~1.0.6:
14241411
dependencies:
14251412
delayed-stream "~1.0.0"
14261413

1427-
commander@^2.12.1, commander@~2.20.0:
1428-
version "2.20.0"
1429-
resolved "https://registry.yarnpkg.com/commander/-/commander-2.20.0.tgz#d58bb2b5c1ee8f87b0d340027e9e94e222c5a422"
1430-
integrity sha512-7j2y+40w61zy6YC2iRNpUe/NwhNyoXrYpHMrSunaMG64nRnaf96zO/KMQR4OyN/UnE5KLyEBnKHd4aG3rskjpQ==
1431-
14321414
commander@^2.20.0:
14331415
version "2.20.3"
14341416
resolved "https://registry.yarnpkg.com/commander/-/commander-2.20.3.tgz#fd485e84c03eb4881c20722ba48035e8531aeb33"
14351417
integrity sha512-GpVkmM8vF2vQUkj2LvZmD35JxeJOLCwJ9cUkugyk2nuhbv3+mJvpLYYt+0+USMxE+oj+ey/lJEnhZw75x/OMcQ==
14361418

1419+
commander@~2.20.0:
1420+
version "2.20.0"
1421+
resolved "https://registry.yarnpkg.com/commander/-/commander-2.20.0.tgz#d58bb2b5c1ee8f87b0d340027e9e94e222c5a422"
1422+
integrity sha512-7j2y+40w61zy6YC2iRNpUe/NwhNyoXrYpHMrSunaMG64nRnaf96zO/KMQR4OyN/UnE5KLyEBnKHd4aG3rskjpQ==
1423+
14371424
compare-func@^1.3.1:
14381425
version "1.3.2"
14391426
resolved "https://registry.yarnpkg.com/compare-func/-/compare-func-1.3.2.tgz#99dd0ba457e1f9bc722b12c08ec33eeab31fa648"
@@ -1861,19 +1848,6 @@ diff-sequences@^26.0.0:
18611848
resolved "https://registry.yarnpkg.com/diff-sequences/-/diff-sequences-26.0.0.tgz#0760059a5c287637b842bd7085311db7060e88a6"
18621849
integrity sha512-JC/eHYEC3aSS0vZGjuoc4vHA0yAQTzhQQldXMeMF+JlxLGJlCO38Gma82NV9gk1jGFz8mDzUMeaKXvjRRdJ2dg==
18631850

1864-
diff@^4.0.1:
1865-
version "4.0.1"
1866-
resolved "https://registry.yarnpkg.com/diff/-/diff-4.0.1.tgz#0c667cb467ebbb5cea7f14f135cc2dba7780a8ff"
1867-
integrity sha512-s2+XdvhPCOF01LRQBC8hf4vhbVmI2CGS5aZnxLJlT5FtdhPCDFq80q++zK2KlrVorVDdL5BOGZ/VfLrVtYNF+Q==
1868-
1869-
1870-
version "0.7.2"
1871-
resolved "https://registry.yarnpkg.com/doctrine/-/doctrine-0.7.2.tgz#7cb860359ba3be90e040b26b729ce4bfa654c523"
1872-
integrity sha1-fLhgNZujvpDgQLJrcpzkv6ZUxSM=
1873-
dependencies:
1874-
esutils "^1.1.6"
1875-
isarray "0.0.1"
1876-
18771851
doctrine@^3.0.0:
18781852
version "3.0.0"
18791853
resolved "https://registry.yarnpkg.com/doctrine/-/doctrine-3.0.0.tgz#addebead72a6574db783639dc87a121773973961"
@@ -2108,11 +2082,6 @@ estree-walker@^1.0.1:
21082082
resolved "https://registry.yarnpkg.com/estree-walker/-/estree-walker-1.0.1.tgz#31bc5d612c96b704106b477e6dd5d8aa138cb700"
21092083
integrity sha512-1fMXF3YP4pZZVozF8j/ZLfvnR8NSIljt56UhbZ5PeeDmmGHpgpdwQt7ITlGvYaQukCvuBRMLEiKiYC+oeIg4cg==
21102084

2111-
esutils@^1.1.6:
2112-
version "1.1.6"
2113-
resolved "https://registry.yarnpkg.com/esutils/-/esutils-1.1.6.tgz#c01ccaa9ae4b897c6d0c3e210ae52f3c7a844375"
2114-
integrity sha1-wBzKqa5LiXxtDD4hCuUvPHqEQ3U=
2115-
21162085
esutils@^2.0.2:
21172086
version "2.0.2"
21182087
resolved "https://registry.yarnpkg.com/esutils/-/esutils-2.0.2.tgz#0abf4f1caa5bcb1f7a9d8acc6dea4faaa04bac9b"
@@ -3061,11 +3030,6 @@ is-wsl@^2.1.1:
30613030
resolved "https://registry.yarnpkg.com/is-wsl/-/is-wsl-2.1.1.tgz#4a1c152d429df3d441669498e2486d3596ebaf1d"
30623031
integrity sha512-umZHcSrwlDHo2TGMXv0DZ8dIUGunZ2Iv68YZnrmCiBPkZ4aaOhtv7pXJKeki9k3qJ3RJr0cDyitcl5wEH3AYog==
30633032

3064-
3065-
version "0.0.1"
3066-
resolved "https://registry.yarnpkg.com/isarray/-/isarray-0.0.1.tgz#8a18acfca9a8f4177e09abfc6038939b05d1eedf"
3067-
integrity sha1-ihis/Kmo9Bd+Cav8YDiTmwXR7t8=
3068-
30693033
[email protected], isarray@~1.0.0:
30703034
version "1.0.0"
30713035
resolved "https://registry.yarnpkg.com/isarray/-/isarray-1.0.0.tgz#bb935d48582cba168c06834957a54a3e07124f11"
@@ -5892,63 +5856,11 @@ ts-jest@^26.0.0:
58925856
semver "7.x"
58935857
yargs-parser "18.x"
58945858

5895-
5896-
version "1.9.0"
5897-
resolved "https://registry.yarnpkg.com/tslib/-/tslib-1.9.0.tgz#e37a86fda8cbbaf23a057f473c9f4dc64e5fc2e8"
5898-
integrity sha512-f/qGG2tUkrISBlQZEjEqoZ3B2+npJjIf04H1wuAv9iA8i04Icp+61KRXxFdha22670NJopsZCIjhC3SnjPRKrQ==
5899-
5900-
tslib@^1.8.0:
5901-
version "1.13.0"
5902-
resolved "https://registry.yarnpkg.com/tslib/-/tslib-1.13.0.tgz#c881e13cc7015894ed914862d276436fa9a47043"
5903-
integrity sha512-i/6DQjL8Xf3be4K/E6Wgpekn5Qasl1usyw++dAA35Ue5orEn65VIxOA+YvNNl9HV3qv70T7CNwjODHZrLwvd1Q==
5904-
59055859
tslib@^1.8.1:
59065860
version "1.10.0"
59075861
resolved "https://registry.yarnpkg.com/tslib/-/tslib-1.10.0.tgz#c3c19f95973fb0a62973fb09d90d961ee43e5c8a"
59085862
integrity sha512-qOebF53frne81cf0S9B41ByenJ3/IuH8yJKngAX35CmiZySA0khhkovshKK+jGCaMnVomla7gVlIcc3EvKPbTQ==
59095863

5910-
tslint-eslint-rules@^5.4.0:
5911-
version "5.4.0"
5912-
resolved "https://registry.yarnpkg.com/tslint-eslint-rules/-/tslint-eslint-rules-5.4.0.tgz#e488cc9181bf193fe5cd7bfca213a7695f1737b5"
5913-
integrity sha512-WlSXE+J2vY/VPgIcqQuijMQiel+UtmXS+4nvK4ZzlDiqBfXse8FAvkNnTcYhnQyOTW5KFM+uRRGXxYhFpuBc6w==
5914-
dependencies:
5915-
doctrine "0.7.2"
5916-
tslib "1.9.0"
5917-
tsutils "^3.0.0"
5918-
5919-
5920-
version "5.20.1"
5921-
resolved "https://registry.yarnpkg.com/tslint/-/tslint-5.20.1.tgz#e401e8aeda0152bc44dd07e614034f3f80c67b7d"
5922-
integrity sha512-EcMxhzCFt8k+/UP5r8waCf/lzmeSyVlqxqMEDQE7rWYiQky8KpIBz1JAoYXfROHrPZ1XXd43q8yQnULOLiBRQg==
5923-
dependencies:
5924-
"@babel/code-frame" "^7.0.0"
5925-
builtin-modules "^1.1.1"
5926-
chalk "^2.3.0"
5927-
commander "^2.12.1"
5928-
diff "^4.0.1"
5929-
glob "^7.1.1"
5930-
js-yaml "^3.13.1"
5931-
minimatch "^3.0.4"
5932-
mkdirp "^0.5.1"
5933-
resolve "^1.3.2"
5934-
semver "^5.3.0"
5935-
tslib "^1.8.0"
5936-
tsutils "^2.29.0"
5937-
5938-
tsutils@^2.29.0:
5939-
version "2.29.0"
5940-
resolved "https://registry.yarnpkg.com/tsutils/-/tsutils-2.29.0.tgz#32b488501467acbedd4b85498673a0812aca0b99"
5941-
integrity sha512-g5JVHCIJwzfISaXpXE1qvNalca5Jwob6FjI4AoPlqMusJ6ftFE7IkkFoMhVLRgK+4Kx3gkzb8UZK5t5yTTvEmA==
5942-
dependencies:
5943-
tslib "^1.8.1"
5944-
5945-
tsutils@^3.0.0:
5946-
version "3.14.0"
5947-
resolved "https://registry.yarnpkg.com/tsutils/-/tsutils-3.14.0.tgz#bf8d5a7bae5369331fa0f2b0a5a10bd7f7396c77"
5948-
integrity sha512-SmzGbB0l+8I0QwsPgjooFRaRvHLBLNYM8SeQ0k6rtNDru5sCGeLJcZdwilNndN+GysuFjF5EIYgN8GfFG6UeUw==
5949-
dependencies:
5950-
tslib "^1.8.1"
5951-
59525864
tsutils@^3.17.1:
59535865
version "3.17.1"
59545866
resolved "https://registry.yarnpkg.com/tsutils/-/tsutils-3.17.1.tgz#ed719917f11ca0dee586272b2ac49e015a2dd759"

0 commit comments

Comments
 (0)