-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Description
Documentation Feedback
We have chips-form-control-example, chips-reactive-form-example components that intend to illustrate how chips interact with the form control.
I see 2 problems here.
-
The interaction with
mat-chip-gridis happening not fully through the formControl. For now the source of chips's list iskeywordssignal, not the formControl:@for (keyword of keywords(); track keyword) {
It seems we should take the formControl as the source of chips's list (not the signal):@for (keyword of formControl.value || []; track keyword) {
Moreover we could get rid of the signal, because the goal of the example is to show the interaction between the formControl and the chips in the template. -
These two examples of
chips-form-control-exampleandchips-reactive-form-examplecomponents duplicate each other. They have the same logic inside of components classes. So it seems we could leave only one of these two examples.