Skip to content

Commit 3e60055

Browse files
committed
main - 78bd12c fix(ng-dev/ts-circular-dependencies): print errors when goldens are disabled (#2673)
1 parent d25ced2 commit 3e60055

File tree

7 files changed

+14
-11
lines changed

7 files changed

+14
-11
lines changed

bundles/cli.mjs

+3-2
Original file line numberDiff line numberDiff line change
@@ -39951,7 +39951,7 @@ import * as fs3 from "fs";
3995139951
import lockfile from "@yarnpkg/lockfile";
3995239952
var import_dependency_path = __toESM(require_lib7());
3995339953
async function verifyNgDevToolIsUpToDate(workspacePath) {
39954-
const localVersion = `0.0.0-27078026111b01a7202449e9788ce38f2b2e103f`;
39954+
const localVersion = `0.0.0-78bd12c8526c396fc85e5ac3d72c039dc7e0a51a`;
3995539955
const workspacePackageJsonFile = path6.join(workspacePath, workspaceRelativePackageJsonPath);
3995639956
const pnpmLockFile = path6.join(workspacePath, "pnpm-lock.yaml");
3995739957
const yarnLockFile = path6.join(workspacePath, "yarn.lock");
@@ -40696,7 +40696,8 @@ function main(approve, config, printWarnings) {
4069640696
return 1;
4069740697
}
4069840698
if (cycles.length > 0) {
40699-
Log.error(`x No circular dependencies are allow within this repository.`);
40699+
Log.error(`x No circular dependencies are allow within this repository, but circular dependencies were found:`);
40700+
actual.forEach((c) => Log.error(` \u2022 ${convertReferenceChainToString(c)}`));
4070040701
return 1;
4070140702
}
4070240703
Log.info(green("\u2714 No circular dependencies found in this repository."));

bundles/cli.mjs.map

+2-2
Large diffs are not rendered by default.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@angular/ng-dev",
3-
"version": "0.0.0-27078026111b01a7202449e9788ce38f2b2e103f",
3+
"version": "0.0.0-78bd12c8526c396fc85e5ac3d72c039dc7e0a51a",
44
"type": "module",
55
"private": true,
66
"bin": "./bundles/cli.mjs",

ts-circular-dependencies/index.js

+3-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ts-circular-dependencies/index.mjs

+3-2
Large diffs are not rendered by default.

utils/version-check.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

utils/version-check.mjs

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import { tryGetPackageId } from '@pnpm/dependency-path';
2323
*/
2424
export async function verifyNgDevToolIsUpToDate(workspacePath) {
2525
// The placeholder will be replaced by the `pkg_npm` substitutions.
26-
const localVersion = `0.0.0-27078026111b01a7202449e9788ce38f2b2e103f`;
26+
const localVersion = `0.0.0-78bd12c8526c396fc85e5ac3d72c039dc7e0a51a`;
2727
const workspacePackageJsonFile = path.join(workspacePath, workspaceRelativePackageJsonPath);
2828
const pnpmLockFile = path.join(workspacePath, 'pnpm-lock.yaml');
2929
const yarnLockFile = path.join(workspacePath, 'yarn.lock');

0 commit comments

Comments
 (0)