Skip to content

Commit 89624a6

Browse files
committed
ci: remove cache usage from privileged environment (#2078)
Remove the usage of cache from a privileged environments PR Close #2078
1 parent 3d31a11 commit 89624a6

File tree

3 files changed

+7
-17
lines changed

3 files changed

+7
-17
lines changed

.github/workflows/ng-renovate.yml

-11
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,6 @@ jobs:
1616
runs-on: ubuntu-latest
1717
steps:
1818
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
19-
- name: Get current date
20-
id: date
21-
run: echo "date=$(date +'%Y-%m-%d')" >> $GITHUB_OUTPUT
22-
# Note: we use `date` as part of the key hash so that we create a new cache every day.
23-
# We do not use `restore-keys` so that the cache does not keep growing.
24-
- uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
25-
with:
26-
path: |
27-
.github/ng-renovate/node-modules
28-
/tmp/renovate
29-
key: v2-renovate-${{hashFiles('.github/ng-renovate/yarn.lock')}}-${{ steps.date.outputs.date }}
3019
- run: yarn --cwd .github/ng-renovate install --immutable
3120
shell: bash
3221

.github/workflows/pr.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: CI
1+
name: Pull Request
22

33
on:
44
pull_request:

github-actions/npm/checkout-and-setup-node/action.yml

+6-5
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,9 @@ runs:
4444
node-version: ${{ inputs.node-version }}
4545
cache: 'yarn'
4646

47-
- uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
48-
if: ${{ inputs.cache-node-modules == 'true' }}
49-
with:
50-
path: ${{ inputs.node-module-directories }}
51-
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock', '**/*.patch') }}
47+
# TODO(josephperrott): Determine if its safe to use this caching step.
48+
# - uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
49+
# if: ${{ inputs.cache-node-modules == 'true' }}
50+
# with:
51+
# path: ${{ inputs.node-module-directories }}
52+
# key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock', '**/*.patch') }}

0 commit comments

Comments
 (0)