feat(reminders): replace old notification permission request logic

GSoC 2025: Review Reminders

The old code requested notification permissions via MyAccount and requests the permission each time a new user logs in, which makes no sense. Notifications are tied to the phone the app is installed on, not an individual user profile. Rather, we should be requesting notification permissions when the user first triggers a sync. This is what this change accomplishes.

Deletes all old logic for requesting notification permissions. Deletes `checkNotificationPermission` as it has been moved to Permissions as `shouldRequestNotificationPermissions`. Requests notification permissions the first time the user triggers a sync.

Author: ericli3690

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

@@ -184,6 +184,7 @@ import com.ichi2.utils.ImportUtils
 import com.ichi2.utils.ImportUtils.ImportResult
 import com.ichi2.utils.NetworkUtils
 import com.ichi2.utils.NetworkUtils.isActiveNetworkMetered
+import com.ichi2.utils.Permissions
 import com.ichi2.utils.VersionUtils
 import com.ichi2.utils.cancelable
 import com.ichi2.utils.checkBoxPrompt
@@ -501,11 +502,6 @@ open class DeckPicker :
         }
     }
 
-    private val notificationPermissionLauncher =
-        registerForActivityResult(ActivityResultContracts.RequestPermission()) {
-            Timber.i("notification permission: %b", it)
-        }
-
     // ----------------------------------------------------------------------------
     // ANDROID ACTIVITY METHODS
     // ----------------------------------------------------------------------------
@@ -2122,7 +2118,12 @@ open class DeckPicker :
             return
         }
 
-        MyAccount.checkNotificationPermission(this, notificationPermissionLauncher)
+        // Request notification permissions from the user if they have not been requested ever before
+        if (!Prefs.syncNotifsRequestShown) {
+            Permissions.requestNotificationsPermissionIfNeeded(context = this, supportFragmentManager) {
+                Prefs.syncNotifsRequestShown = true
+            }
+        }
 
         /** Nested function that makes the connection to
          * the sync server and starts syncing the data */

AnkiDroid/src/main/java/com/ichi2/anki/MyAccount.kt

@@ -13,8 +13,6 @@
  ****************************************************************************************/
 package com.ichi2.anki
 
-import android.content.Context
-import android.content.pm.PackageManager
 import android.content.res.Configuration
 import android.os.Build
 import android.os.Bundle
@@ -27,10 +25,7 @@ import android.widget.Button
 import android.widget.ImageView
 import android.widget.TextView
 import androidx.activity.OnBackPressedCallback
-import androidx.activity.result.ActivityResultLauncher
-import androidx.activity.result.contract.ActivityResultContracts
 import androidx.appcompat.widget.Toolbar
-import androidx.core.content.ContextCompat
 import androidx.core.view.isVisible
 import com.google.android.material.textfield.TextInputEditText
 import com.google.android.material.textfield.TextInputLayout
@@ -43,7 +38,6 @@ import com.ichi2.anki.utils.ext.removeFragmentFromContainer
 import com.ichi2.anki.utils.ext.showDialogFragment
 import com.ichi2.ui.TextInputEditField
 import com.ichi2.utils.AdaptionUtil.isUserATestClient
-import com.ichi2.utils.Permissions
 import net.ankiweb.rsdroid.exceptions.BackendSyncException
 import timber.log.Timber
 
@@ -98,11 +92,6 @@ open class MyAccount : AnkiActivity() {
         }
     }
 
-    private val notificationPermissionLauncher =
-        registerForActivityResult(ActivityResultContracts.RequestPermission()) {
-            Timber.i("notification permission: %b", it)
-        }
-
     override fun onCreate(savedInstanceState: Bundle?) {
         if (showedActivityFailedScreen(savedInstanceState)) {
             return
@@ -137,7 +126,7 @@ open class MyAccount : AnkiActivity() {
             return
         }
         Timber.i("Attempting auto-login")
-        handleNewLogin(username, password, notificationPermissionLauncher)
+        handleNewLogin(username, password)
     }
 
     private fun login() {
@@ -146,7 +135,7 @@ open class MyAccount : AnkiActivity() {
         inputMethodManager.hideSoftInputFromWindow(username.windowToken, 0)
         val username = username.text.toString().trim() // trim spaces, issue 1586
         val password = password.text.toString()
-        handleNewLogin(username, password, notificationPermissionLauncher)
+        handleNewLogin(username, password)
     }
 
     private fun logout() {
@@ -332,7 +321,6 @@ open class MyAccount : AnkiActivity() {
     private fun handleNewLogin(
         username: String,
         password: String,
-        resultLauncher: ActivityResultLauncher<String>,
     ) {
         val endpoint = getEndpoint()
         launchCatchingTask {
@@ -355,7 +343,6 @@ open class MyAccount : AnkiActivity() {
                 }
             updateLogin(username, auth.hkey)
             setResult(RESULT_OK)
-            checkNotificationPermission(this@MyAccount, resultLauncher)
             finish()
         }
     }
@@ -364,33 +351,5 @@ open class MyAccount : AnkiActivity() {
         @KotlinCleanup("change to enum")
         internal const val STATE_LOG_IN = 1
         internal const val STATE_LOGGED_IN = 2
-
-        /**
-         * Displays a system prompt: "Allow AnkiDroid to send you notifications"
-         *
-         * [launcher] receives a callback result (`boolean`) unless:
-         *  * Permissions were already granted
-         *  * We are < API 33
-         *
-         * Permissions may permanently be denied, in which case [launcher] immediately
-         * receives a failure result
-         */
-        fun checkNotificationPermission(
-            context: Context,
-            launcher: ActivityResultLauncher<String>,
-        ) {
-            if (Build.VERSION.SDK_INT < Build.VERSION_CODES.TIRAMISU) {
-                return
-            }
-            val permission = Permissions.postNotification
-            if (permission != null &&
-                ContextCompat.checkSelfPermission(
-                    context,
-                    permission,
-                ) != PackageManager.PERMISSION_GRANTED
-            ) {
-                launcher.launch(permission)
-            }
-        }
     }
 }