Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

Investigate output-dir for source maps #404

Open
arichiardi opened this issue May 15, 2018 · 0 comments
Open

Investigate output-dir for source maps #404

arichiardi opened this issue May 15, 2018 · 0 comments

Comments

@arichiardi
Copy link
Collaborator

This is more like a reminder for myself. In #349 I have noticed that we have this setting for source maps:

opts {:output-dir "file://(/goog/..)?"}

https://github.com/anmonteiro/lumo/blob/improve-source-maps/src/cljs/snapshot/lumo/repl.cljs#L699

By looking at core, it seems that output-dir is always pointing to the folder where the maps are included:

https://github.com/clojure/clojurescript/blob/20a6e1fcd8724ad65a3776112dcc7bfd5124a094/src/main/cljs/cljs/stacktrace.cljc#L497
https://github.com/clojure/clojurescript/blob/20a6e1fcd8724ad65a3776112dcc7bfd5124a094/src/main/cljs/cljs/stacktrace.cljc#L551

In our case it is a bit more complicated to decide where to point, because we partly embed main.js.map (after #349 is in) and partily use .lumo_cache or any arbitrary cache folder with -k.

So what should go in output-dir is to be investigated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant