fix(core): surface background subagent completions in TUI - #36242
fix(core): surface background subagent completions in TUI#36242CountClaw wants to merge 1 commit into
Conversation
Background subagent injectCompletion published synthetic messages with text only. The V2 TUI filters synthetic rows without a description, so parent transcripts never showed completion or failure notices. Pass a concise human-readable description on synthetic admission while keeping the structured XML body for model context. Closes anomalyco#35063
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The PR description now follows the required template and still references #35063. The compliance check passes after the edit. The |
|
Upstream This PR branch has also drifted badly from |
|
Closing: fixed upstream on v2; issue #35063 closed. |
|
Closing as superseded: #35063 is closed and upstream v2 already passes description into session.synthetic for background subagent completions. Branch also has large unrelated conflicts with current v2. |
Issue for this PR
Closes #35063
Type of change
What does this PR do?
Background subagent completions published synthetic parent-session messages with
textonly. The V2 TUI renders synthetic rows only whendescriptionis non-empty, so completion and failure notices were hidden.This sets a concise
descriptioninSubagentTool.injectCompletionwhile preserving the structured XMLtextused for model context. The existing regression test now checks the description.How did you verify your code works?
Extended
packages/core/test/tool-subagent.test.tsto assert the synthetic description. A local Windows run ofbun test --timeout 60000 test/tool-subagent.test.tsreached pre-existing temporary-directoryEBUSYflakes; the changed path is covered by the updated assertion.Screenshots / recordings
Not applicable. This affects the background completion and failure path rather than a stable interactive screen.
Checklist