Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Actions for when PR is open to run tests #5

Open
anontyro opened this issue Sep 29, 2021 · 0 comments
Open

Add Actions for when PR is open to run tests #5

anontyro opened this issue Sep 29, 2021 · 0 comments
Assignees
Labels

Comments

@anontyro
Copy link
Owner

anontyro commented Sep 29, 2021

Background

As a contributor I would like to know that my changes will not break any existing code in the project and would like feedback given to me

Implementation Details

  • Add in a new gitHub Action hook for when a PR is open to run all the tests
  • Consider where we can post the results
  • If tests fail the item should not be merge-able until the tests pass
  • improve test coverage also

Acceptance Criteria

  • When I open a new PR i should see the action fire
  • When my all my tests pass I should be allowed to merge
  • when my tests don't pass merging should not be allowed
@anontyro anontyro self-assigned this Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant