api_modify container cmd error - got multiple values

[maksimsamt]

Related with v3170-a1 release.

    - name: Container add
      community.routeros.api_modify:
        path: container
        data:
          - name: nginx
            remote-image: nginx
            interface: veth1
            ...
            entrypoint: "sleep"
            cmd: "infinity"
            hostname: my.hostname

Error:

fatal: [localhost]: FAILED! => {"changed": false, "msg": "Task failed: Module failed: Path.__call__() got multiple values for argument 'cmd'"}

with --check --diff

--- before
+++ after
@@ -1,3 +1,19 @@
 {
-    "data": []
+    "data": [
+        {
+            "cmd": "infinity",
+            "entrypoint": "sleep",
+            "hostname": "my.hostname",
+            "interface": "veth1",
+            "name": "nginx",
+            "remote-image": "nginx"
+        }
+    ]
 }

Versions:

Ansible v2.20.2
ansible.netcommon 8.2.1
community.routeros 3.17.0-a2

Env:

Mikrotik RouterOS 7.21

[felixfontein]

CC @FelixRicke

I think this is a problem with librouteros though, since Path.add(**kwargs) (https://github.com/luqasz/librouteros/blob/c2d8719ed3e59564015acc463c8fef24bc33ab3f/src/librouteros/api.py#L131-L136) calls Path.__call__(cmd="add", **kwargs) (https://github.com/luqasz/librouteros/blob/c2d8719ed3e59564015acc463c8fef24bc33ab3f/src/librouteros/api.py#L109-L113), and thus for this path, __call__() gets two arguments called cmd: cmd="add" and cmd="infinity".

[felixfontein]

I created luqasz/librouteros#356 for this, and included some thoughts about how to work around this. The next step would be figuring out how compatible this approach is to older versions of librouteros...

[felixfontein]

librouteros 3.4.2 should fix this, @maksimsamt can you try it out? From the code I'm pretty sure it should work, but I don't have a router which supports /container so I can't fully test myself :)

[maksimsamt]

Thank you very much for such quick support and fix!
@felixfontein ,
Tested with librouteros 3.4.2 and now cmd works as expected.

[felixfontein]

Well, all the real work has been done by @luqasz :)