Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pypi project and automate the build and publish #51

Open
Alex-Izquierdo opened this issue Feb 4, 2025 · 4 comments
Open

Create pypi project and automate the build and publish #51

Alex-Izquierdo opened this issue Feb 4, 2025 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Alex-Izquierdo
Copy link
Collaborator

Now that dispatcher is a public project and the library can be implemented in other projects we need a basic automation to build the library and publish it to pypi.
Jira: https://issues.redhat.com/browse/AAP-39790

@AlanCoding
Copy link
Member

With #55 now producing an artifact, I want to start thinking about a "data package" that we could produce for this library. This would include that artifact, but also include some other metrics that are internally generated (the pytest-benchmark is very narrow about measuring times, not other metrics). This would include memory footprint with a certain number of workers, open file descriptors, and others. I might file this in a new issue. But I mention it here, because this would be most valuable if we could attach that data package along with each release, so that we have references.

@Alex-Izquierdo
Copy link
Collaborator Author

Are you saying that the published package would include metrics related to performance or tests? That would seem to a bit odd.
Instead I think for a given ref we can provide such a data but not included in the package itself. Do you know some other project that does something simillar?

@AlanCoding
Copy link
Member

Instead I think for a given ref we can provide such a data but not included in the package itself.

Yeah, that's what I was thinking. Sorry wasn't clear.

Right now I have it uploading an artifact in the .github definition. But this only produces the artifact per each run, which is associated with a PR and expires. We would ideally like to save non-expiring artifacts at the time of release. Ideally, not adding a whole bunch of work or maintenance to accomplish this.

@Alex-Izquierdo
Copy link
Collaborator Author

Alex-Izquierdo commented Feb 10, 2025

Instead I think for a given ref we can provide such a data but not included in the package itself.

Yeah, that's what I was thinking. Sorry wasn't clear.

Right now I have it uploading an artifact in the .github definition. But this only produces the artifact per each run, which is associated with a PR and expires. We would ideally like to save non-expiring artifacts at the time of release. Ideally, not adding a whole bunch of work or maintenance to accomplish this.

@AlanCoding I think we can just add the data within a test report and tools like codecov can incorporate it. Needs to be confirmed.
Probably we can also add an artifact in the GH release.

@AlanCoding AlanCoding added enhancement New feature or request help wanted Extra attention is needed labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants