Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AAP 2.5 #42

Open
ryancbutler opened this issue Oct 29, 2024 · 6 comments
Open

Support AAP 2.5 #42

ryancbutler opened this issue Oct 29, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@ryancbutler
Copy link

Since AAP 2.5 uses a different API path the provider will need to handle the multiple paths depending on version. I see a test already exists for this but the provider only handles /api/ and not the newer /controller/api found in 2.5

@gravesm gravesm added the bug Something isn't working label Nov 1, 2024
@srlynch1
Copy link

srlynch1 commented Nov 26, 2024

The code here is actually committed to dynamically calculate the correct api end points. Nothing needs to be statically configured.

Suggest perhaps just cutting a new release we made zero changes and it's fully functional just with a new provider build with your existing code as this was already committed post 1.0 release.

@Sokren
Copy link

Sokren commented Dec 17, 2024

Hello,
I have the same issue with the AAP provider available on Terraform, and it is not finding the correct path for version 2.5.
Here are some screenshots showing the problem.
Capture d’écran 2024-12-17 à 16 19 17
API Version

@ryancbutler
Copy link
Author

As a workaround, I forked the repo and adjusted the API pathing https://registry.terraform.io/providers/ryancbutler/aap/latest

@srlynch1
Copy link

srlynch1 commented Dec 19, 2024

You don't need to change the API pathing, dynamic pathing is already in place and works regardless if 2.4 or 2.5.

Red Hat just need to release a new provider build. The PR was already merged here #30

@ryancbutler
Copy link
Author

The code here is actually committed to dynamically calculate the correct api end points. Nothing needs to be statically configured.

Suggest perhaps just cutting a new release we made zero changes and it's fully functional just with a new provider build with your existing code as this was already committed post 1.0 release.

Sorry to bump. But is this a possible request? Would help out a lot with our 2.5 deployment.

@GomathiselviS
Copy link
Contributor

Thank you for reporting the issue. The new version of terraform-provider-aap, which will include support for dynamic pathing, will be released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants