FIX: added property file unit to import_3d model #6678
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6678 +/- ##
==========================================
+ Coverage 80.48% 82.65% +2.17%
==========================================
Files 244 244
Lines 77672 77672
==========================================
+ Hits 62511 64199 +1688
+ Misses 15161 13473 -1688 🚀 New features to boost your workflow:
|
Samuelopez-ansys
requested changes
Sep 24, 2025
| merge_planar_faces : bool, optional | ||
| Whether to merge planar faces during import. The default is ``True``. | ||
| input_file_unit: str, optional | ||
| Uinit for the stl file. |
There was a problem hiding this comment.
Typo here: Unit
You could also explain what "Auto" options does
| reduce_error=0, | ||
| merge_planar_faces=True, | ||
| merge_angle=0.02, | ||
| input_file_unit="Auto", |
There was a problem hiding this comment.
Typo here: Unit
You could also explain what "Auto" options does
There was a problem hiding this comment.
I would also rename the variable as simply : "units" It is more pythonic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist