fix: change find split edges default (#2361)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>

Author: 3 people

doc/changelog.d/2361.fixed.md

@@ -0,0 +1 @@
+Change find split edges default

src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py

@@ -65,12 +65,21 @@ def find_split_edges(self, **kwargs) -> dict:  # noqa: D102
         # Create the request - assumes all inputs are valid and of the proper type
         request = FindSplitEdgesRequest(
             bodies_or_faces=kwargs["bodies_or_faces"],
-            angle=DoubleValue(value=float(from_measurement_to_server_angle(kwargs["angle"]))),
-            distance=DoubleValue(
-                value=float(from_measurement_to_server_length(kwargs["distance"]))
+            angle=(
+                DoubleValue(value=float(from_measurement_to_server_angle(kwargs["angle"])))
+                if kwargs["angle"] is not None
+                else None
+            ),
+            distance=(
+                DoubleValue(value=float(from_measurement_to_server_length(kwargs["distance"])))
+                if kwargs["distance"] is not None
+                else None
             ),
         )
 
+        print("distance:", request.distance)
+        print("angle:", request.angle)
+
         # Call the gRPC service
         response = self.stub.FindSplitEdges(request)
 

src/ansys/geometry/core/tools/repair_tools.py

@@ -99,8 +99,8 @@ def __init__(self, grpc_client: GrpcClient, modeler: "Modeler", _internal_use: b
     def find_split_edges(
         self,
         bodies: list["Body"],
-        angle: Angle | pint.Quantity | Real = 0.0,
-        length: Distance | pint.Quantity | Real = 0.0,
+        angle: Angle | pint.Quantity | Real = None,
+        length: Distance | pint.Quantity | Real = None,
     ) -> list[SplitEdgeProblemAreas]:
         """Find split edges in the given list of bodies.
 
@@ -112,9 +112,9 @@ def find_split_edges(
         bodies : list[Body]
             List of bodies that split edges are investigated on.
         angle : Angle | ~pint.Quantity | Real
-            The maximum angle between edges.
+            The maximum angle between edges. By default, None.
         length : Distance | ~pint.Quantity | Real
-            The maximum length of the edges.
+            The maximum length of the edges. By default, None.
 
         Returns
         -------
@@ -127,9 +127,17 @@ def find_split_edges(
         body_ids = [body.id for body in bodies]
 
         # Convert the measurement objects
-        angle = angle if isinstance(angle, Angle) else Angle(angle)
-        length = length if isinstance(length, Distance) else Distance(length)
+        angle = angle if isinstance(angle, Angle) else Angle(angle) if angle is not None else None
+        length = (
+            length
+            if isinstance(length, Distance)
+            else Distance(length)
+            if length is not None
+            else None
+        )
 
+        print("angle:", angle)
+        print("length:", length)
         response = self._grpc_client.services.repair_tools.find_split_edges(
             bodies_or_faces=body_ids, angle=angle, distance=length
         )

tests/integration/test_repair_tools.py

@@ -48,6 +48,14 @@ def test_find_split_edges(modeler: Modeler):
     problem_areas = modeler.repair_tools.find_split_edges(design.bodies, 25, 150)
     assert len(problem_areas) == 3
 
+    # Try with default values
+    problem_areas = modeler.repair_tools.find_split_edges(design.bodies)
+    assert len(problem_areas) == 3
+
+    # Try with values that yield no results
+    problem_areas = modeler.repair_tools.find_split_edges(design.bodies, 0, 0)
+    assert len(problem_areas) == 0
+
 
 def test_find_split_edge_id(modeler: Modeler):
     """Test whether problem area has the id."""