-
Notifications
You must be signed in to change notification settings - Fork 103
Decoupling graphics requirements from libraries #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Added a PR for PyMAPDL: ansys/pymapdl#3820 The visualization was already separated code wise, it was just missing removing it from the main target and adding the graphics target. I think this was made on purpose by @germa89 though, any opinions? |
added a PR for pySpeos: ansys/pyspeos#532 i added error management and warnings so the methods leveraging |
You can probably do a new minor release with this change. |
## Description Comply with [#901](ansys/pyansys#902) Switch from native pyvista to ansys-tools-vizualization-interface only basic implementation done additional steps will be coming ## Issue linked #531 ## Checklist - [x] I have tested my changes locally. - [x] I have added necessary documentation or updated existing documentation. - [x] I have followed the coding style guidelines of this project. - [x] I have added appropriate tests (unit, integration, system). - [x] I have reviewed my changes before submitting this pull request. - [x] I have linked the issue or issues that are solved by the PR if any. - [x] I have assigned this PR to myself. - [x] I have made sure that the title of my PR follows [Conventional commits style](https://www.conventionalcommits.org/en/v1.0.0/#summary) (e.g. ``feat: add optical property``) - [x] I have agreed with the Contributor License Agreement ([CLA](https://developer.ansys.com/form/cla-acceptance)). --------- Co-authored-by: Sebastien Morais <[email protected]> Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sébastien Morais <[email protected]> Co-authored-by: Pengyuan LU <[email protected]>
we created a new minor release it is now available (for pyspeos) |
After the discussions occuring on the PyAnsys Dev meeting, we thought it would be important to decouple the usage of graphics from the main installation of our libraries by defining a "graphics" target for that purpose. See ansys/pyansys-dev-guide#577 and ansys/pyansys-dev-guide#576
By doing a quick analysis of the metapackage and using this script where the variable
target_package
can be easily tweaked... I obtained the following results:Note
In order to run it, one must:
1 - clone the repo
2 - create a venv and activate it
3 - install the repo:
pip install .
4 - install the following:
pip install pyvis pipdeptree
Visualization shows that only 5 packages depend on it directly:
The first 4 should be adapted to use the
ansys-tools-visualization-interface
package if possible, and make it an optional dependency.Now, after investigating the packages that depend on
ansys-tools-visualization-interface
, we get the following list:This means that, only 5 PyAnsys libraries are the ones forcing the installation of PyVista "by default". We should contact each of these repos and push for its separation into a
graphics
target as described in ansys/pyansys-dev-guide#576The text was updated successfully, but these errors were encountered: