feat: Improved error handling (#3646)

* fix: Improved error handling

* fix: Improved error handling

* fix: Improved error handling

* fix: Improved error handling

* fix: restructuring

* Update src/ansys/fluent/core/launcher/error_handler.py

* fix: test fix

* Update src/ansys/fluent/core/launcher/server_info.py

Co-authored-by: Sean Pearson <[email protected]>

* fix: Improvements

* fix: Improvements 1

---------

Co-authored-by: Sean Pearson <[email protected]>

Author: hpohekar

src/ansys/fluent/core/launcher/error_handler.py

@@ -29,6 +29,14 @@ def __init__(self):
         super().__init__("Provide either 'ip' and 'port' or 'server_info_file_name'.")
 
 
+class InvalidIpPort(ValueError):
+    """Raised when IP address and port are invalid."""
+
+    def __init__(self):
+        """Initialize InvalidIpPort."""
+        super().__init__("Provide a valid 'ip' and 'port'.")
+
+
 class UnexpectedKeywordArgument(TypeError):
     """Raised when a valid keyword argument is not specified."""
 

src/ansys/fluent/core/launcher/server_info.py

@@ -6,7 +6,7 @@
 
 from ansys.fluent.core.fluent_connection import PortNotProvided
 from ansys.fluent.core.launcher import launcher_utils
-from ansys.fluent.core.launcher.error_handler import IpPortNotProvided
+from ansys.fluent.core.launcher.error_handler import InvalidIpPort, IpPortNotProvided
 from ansys.fluent.core.session import _parse_server_info_file
 
 
@@ -45,6 +45,27 @@ def _get_server_info_file_names(use_tmpdir=True) -> tuple[str, str]:
         return file_name, file_name
 
 
+def _check_ip_port(ip: str, port: int):
+    """Check if a port is open on a given IP address."""
+
+    if not (ip and port):
+        raise IpPortNotProvided()
+
+    if not port:
+        raise PortNotProvided()
+
+    import socket
+
+    sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
+    sock.settimeout(2)
+    try:
+        result = sock.connect_ex((ip, port))
+        if result != 0:
+            raise InvalidIpPort()
+    finally:
+        sock.close()
+
+
 def _get_server_info(
     server_info_file_name: str,
     ip: str | None = None,
@@ -65,7 +86,6 @@ def _get_server_info(
         ip = ip or os.getenv("PYFLUENT_FLUENT_IP", "127.0.0.1")
         port = port or os.getenv("PYFLUENT_FLUENT_PORT")
 
-    if not port:
-        raise PortNotProvided()
+    _check_ip_port(ip=ip, port=port)
 
     return ip, port, password

tests/test_launcher.py

@@ -13,6 +13,7 @@
 from ansys.fluent.core.launcher import launcher_utils
 from ansys.fluent.core.launcher.error_handler import (
     GPUSolverSupportError,
+    InvalidIpPort,
     LaunchFluentError,
     _raise_non_gui_exception_in_windows,
 )
@@ -534,3 +535,8 @@ def test_container_ports():
     with pyfluent.launch_fluent(container_dict=container_dict) as session:
         session._container.reload()
         assert len(session._container.ports) == 2
+
+
+def test_correct_ip_port():
+    with pytest.raises(InvalidIpPort):
+        pyfluent.connect_to_fluent(ip="1.2.3.4", port=5555)

tests/test_session.py

@@ -435,12 +435,6 @@ def mock_parse_server_info_file(file_name):
     assert ex.value.__context__.__context__.code() == grpc.StatusCode.UNAVAILABLE
 
 
-def test_recover_grpc_error_from_connection_error():
-    with pytest.raises(RuntimeError) as ex:
-        pyfluent.connect_to_fluent(ip="127.0.0.1", port=50000, password="abcdefg")
-    assert ex.value.__context__.code() == grpc.StatusCode.UNAVAILABLE
-
-
 def test_solver_methods(new_solver_session):
     solver = new_solver_session