Update system tests in google provider. Add constraints to prevent from failing and modify example_cloud_logging_sink (#55939)

Co-authored-by: Anton Nitochkin <[email protected]>

Author: Crowiant

providers/google/tests/system/google/ads/example_ads.py

@@ -61,7 +61,7 @@
 
 # [START howto_google_ads_env_variables]
 ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID", "default")
-PROJECT_ID = os.environ.get("SYSTEM_TESTS_PROJECT_ID", "default")
+PROJECT_ID = os.environ.get("SYSTEM_TESTS_GCP_PROJECT", "default")
 API_VERSION = "v21"
 
 DAG_ID = "google_ads"

providers/google/tests/system/google/cloud/cloud_logging_sink/example_cloud_logging_sink.py

@@ -32,27 +32,38 @@
     CloudLoggingListSinksOperator,
     CloudLoggingUpdateSinkOperator,
 )
+from airflow.providers.google.cloud.operators.gcs import GCSCreateBucketOperator, GCSDeleteBucketOperator
+
+try:
+    from airflow.sdk import TriggerRule
+except ImportError:
+    # Compatibility for Airflow < 3.1
+    from airflow.utils.trigger_rule import TriggerRule  # type: ignore[no-redef,attr-defined]
 
 PROJECT_ID = os.environ.get("SYSTEM_TESTS_GCP_PROJECT", "default")
 ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID", "default")
+DAG_ID = "gcp_cloud_logging_sink"
+BUCKET_NAME = f"bucket_{DAG_ID}_{ENV_ID}"
 
 SINK_NAME = "example-airflow-test-sink"
 CONN_ID = "google_cloud_default"
 
 with DAG(
-    dag_id="google_cloud_logging_sink",
+    dag_id=DAG_ID,
     schedule="@once",
     start_date=datetime(2024, 1, 1),
     catchup=False,
     tags=["example", "gcp", "cloud-logging"],
 ) as dag:
+    create_bucket = GCSCreateBucketOperator(task_id="create_bucket", bucket_name=BUCKET_NAME)
+
     # [START howto_operator_cloud_logging_create_sink_native_obj]
     create_sink = CloudLoggingCreateSinkOperator(
         task_id="create_sink",
         project_id=PROJECT_ID,
         sink_config={
             "name": SINK_NAME,
-            "destination": "storage.googleapis.com/test-log-sink-af",
+            "destination": f"storage.googleapis.com/{BUCKET_NAME}",
             "description": "Create with full sink_config",
             "filter": "severity>=INFO",
             "disabled": False,
@@ -110,7 +121,11 @@
     )
     # [END howto_operator_cloud_logging_delete_sink]
 
-    (create_sink >> update_sink_config >> list_sinks_after >> delete_sink)
+    delete_bucket = GCSDeleteBucketOperator(
+        task_id="delete_bucket", bucket_name=BUCKET_NAME, trigger_rule=TriggerRule.ALL_DONE
+    )
+
+    (create_bucket >> create_sink >> update_sink_config >> list_sinks_after >> delete_sink >> delete_bucket)
 
     from tests_common.test_utils.watcher import watcher
 

providers/google/tests/system/google/cloud/vertex_ai/example_vertex_ai_feature_store.py

@@ -23,6 +23,8 @@
 from __future__ import annotations
 
 import os
+import random
+import string
 from datetime import datetime, timedelta
 
 from google.cloud.aiplatform_v1beta1 import FeatureOnlineStore, FeatureView, FeatureViewDataKey
@@ -61,7 +63,11 @@
 BQ_VIEW_ID = "product_features_view"
 BQ_VIEW_FQN = f"{PROJECT_ID}.{BQ_DATASET_ID}.{BQ_VIEW_ID}"
 
-FEATURE_ONLINE_STORE_ID = f"my_feature_online_store_unique_{ENV_ID}"
+# Please take into consideration that max ID length is 60 symbols
+PREFIX_FEATURE_ONLINE_STORE_ID = "".join(
+    random.choice(string.ascii_letters + string.digits) for _ in range(20)
+)
+FEATURE_ONLINE_STORE_ID = f"feature_online_store_{PREFIX_FEATURE_ONLINE_STORE_ID}".replace("-", "_")
 FEATURE_VIEW_ID = "feature_view_product"
 FEATURE_VIEW_DATA_KEY = {"key": "28098"}
 

providers/google/tests/system/google/marketing_platform/example_display_video.py

@@ -83,7 +83,7 @@
 ADVERTISER_ID = "{{ task_instance.xcom_pull('get_display_video_advertiser_id') }}"
 GMP_PARTNER_ID = "{{ task_instance.xcom_pull('get_display_video_gmp_partner_id') }}"
 SDF_VERSION = "SDF_VERSION_8_1"
-BQ_DATASET = f"bq_dataset_{DAG_ID}_{ENV_ID}"
+BQ_DATASET = f"bq_dataset_{DAG_ID}_{ENV_ID}".replace("-", "_")
 ENTITY_TYPE = "CAMPAIGN"
 ERF_SOURCE_OBJECT = GoogleDisplayVideo360Hook.erf_uri(GMP_PARTNER_ID, ENTITY_TYPE)