Add test coverage to verify k8s tags existed in docker hub #55938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
requested review from
amoghrajesh,
ashb,
gopidesupavan,
jedcunningham and
potiuk
as code owners
amoghrajesh
reviewed
Sep 22, 2025
Comment on lines
+25
to
+34
| class TestGlobalConstants: | ||
| @pytest.mark.parametrize("k8s_version", ALLOWED_KUBERNETES_VERSIONS) | ||
| def test_kubernetes_versions_available_on_docker_hub(self, k8s_version): | ||
| """Test that all Kubernetes versions in ALLOWED_KUBERNETES_VERSIONS exist on Docker Hub.""" | ||
| url = f"https://registry.hub.docker.com/v2/repositories/kindest/node/tags/{k8s_version}/" | ||
| response = requests.get(url, timeout=10) | ||
| assert response.status_code == 200, f"Kubernetes version {k8s_version} not found on Docker Hub" | ||
|
|
||
| data = response.json() | ||
| assert data["name"] == k8s_version, f"Version mismatch for {k8s_version}" |
There was a problem hiding this comment.
A little excessive to run on every PR? I would rather it be a github CI job that runs only when global constants are changed?
There was a problem hiding this comment.
My concern is around extra API calls (not a veto but worth thinking it)
There was a problem hiding this comment.
Do you mean in dev/breeze/tests/test_selective_checks.py ?
There was a problem hiding this comment.
No, i was suggesting to not have a "unit test" for this but instead a github CI job that only runs when global_constants are changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #55934