Skip to content

enhancement: rename redis keepalive parameters in rate limiting plugins #12954

@kayx23

Description

@kayx23

Description

PR #12861 introduces two parameters (keepalive_timeout and keepalive_pool) to rate limiting plugins (limit-count, limit-conn, limit-req).

The parameter names, keepalive_timeout and keepalive_pool, are not very consistent with the rest of the Redis related parameters, which are prefixed by redis_.

Image

Additionally, there was a discussion for the ai-rate-limiting plugin to support Redis, and the parameter controlling the redis keepalive timeout shall be named redis_keepalive_timeout.

Feature added by #12861 is about to be released with 3.15.0. Given the above considerations, it would be better to rename keepalive_timeout and keepalive_pool to redis_keepalive_timeout and redis_keepalive_pool before the release for improved clarity and to prevent a future breaking change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    Status

    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions