Skip to content

Conversation

@sudhiremmadi
Copy link
Contributor

No description provided.

@github-actions github-actions bot added this to the ADBC Libraries 21 milestone Nov 4, 2025
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's hard for me to be sure because of the layering in this code, but it looks like previously some of the connections had their readers initialized with enableBatchSizeStopConditionDefault = false but now all of them have a default value of true. Did I read that correctly? If so, is that change deliberate and could it be breaking?

@sudhiremmadi
Copy link
Contributor Author

Thanks! It's hard for me to be sure because of the layering in this code, but it looks like previously some of the connections had their readers initialized with enableBatchSizeStopConditionDefault = false but now all of them have a default value of true. Did I read that correctly? If so, is that change deliberate and could it be breaking?

Changed the default value back to false, Thanks

@CurtHagenlocher
Copy link
Contributor

Thanks! It's hard for me to be sure because of the layering in this code, but it looks like previously some of the connections had their readers initialized with enableBatchSizeStopConditionDefault = false but now all of them have a default value of true. Did I read that correctly? If so, is that change deliberate and could it be breaking?

Changed the default value back to false, Thanks

I'm sorry; I wasn't very clear about this. Two of the connections had a value of false but the others seemed to have a value of true. Let me take another look and enumerate this more precisely as I've deleted my notes from yesterday :(.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants