refactor!: move delete to ObjectStoreExt
#549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
force-pushed
the
crepererum/delete-to-ext
branch
from
f32e43a to
cf8f027
Compare
Contributor
|
@crepererum noted that it turns out that the semantics are subtly different in some error case, though it isn't clear if this difference is purpose. |
7 tasks
The normal delete is really just a bulk delete with a single entry. Part of apache#385.
crepererum
force-pushed
the
crepererum/delete-to-ext
branch
from
cf8f027 to
9ff5539
Compare
Contributor
Author
|
@alamb I've fixed the difference. The AWS tests now pass the same way as before. |
alamb
approved these changes
Dec 12, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Makes sense to me -- thank you @crepererum
FYI @kylebarron
I think once this PR is merged, we can make a release candidate
| store: "ext", | ||
| source: "`delete_stream` was supposed to yield once but didn't".into(), | ||
| })?; | ||
| if stream.next().await.is_some() { |
Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ObjectStoretrait: Split out convenience methods #385ObjectStoreExttrait #405.Rationale for this change
deleteis justdelete_streamwith a single element.What changes are included in this PR?
Are there any user-facing changes?
Breaking:
deletemoved fromObjectStoretoObjectStoreExt.