Skip to content

Commit 3d5d04b

Browse files
authored
Enable some advanced state validates runner tests for dataflow legacy and v2. (#36808)
1 parent 8ef3a24 commit 3d5d04b

File tree

5 files changed

+7
-24
lines changed

5 files changed

+7
-24
lines changed
Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
{
2-
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
32
"comment": "Modify this file in a trivial way to cause this test suite to run",
4-
"modification": 2,
5-
"https://github.com/apache/beam/pull/34294": "noting that PR #34294 should run this test",
6-
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface"
3+
"modification": 3,
74
}
Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
11
{
2-
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
32
"comment": "Modify this file in a trivial way to cause this test suite to run",
4-
"https://github.com/apache/beam/pull/31156": "noting that PR #31156 should run this test",
5-
"https://github.com/apache/beam/pull/31268": "noting that PR #31268 should run this test",
6-
"https://github.com/apache/beam/pull/31490": "noting that PR #31490 should run this test",
7-
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface",
8-
"https://github.com/apache/beam/pull/36631": "dofn lifecycle",
3+
"modification": 1,
94
}
Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
11
{
2-
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
32
"comment": "Modify this file in a trivial way to cause this test suite to run",
4-
"https://github.com/apache/beam/pull/31156": "noting that PR #31156 should run this test",
5-
"https://github.com/apache/beam/pull/31268": "noting that PR #31268 should run this test",
6-
"https://github.com/apache/beam/pull/31490": "noting that PR #31490 should run this test",
7-
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface",
8-
"https://github.com/apache/beam/pull/36631": "dofn lifecycle validation",
3+
"modification": 2
94
}
Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
{
2-
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
32
"comment": "Modify this file in a trivial way to cause this test suite to run",
4-
"https://github.com/apache/beam/pull/31156": "noting that PR #31156 should run this test",
5-
"https://github.com/apache/beam/pull/31268": "noting that PR #31268 should run this test",
6-
"https://github.com/apache/beam/pull/31490": "noting that PR #31490 should run this test"
3+
"modification": 1,
74
}

runners/google-cloud-dataflow-java/build.gradle

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,6 @@ def commonLegacyExcludeCategories = [
205205
'org.apache.beam.sdk.testing.UsesExternalService',
206206
'org.apache.beam.sdk.testing.UsesDistributionMetrics',
207207
'org.apache.beam.sdk.testing.UsesGaugeMetrics',
208-
'org.apache.beam.sdk.testing.UsesMultimapState',
209208
'org.apache.beam.sdk.testing.UsesTestStream',
210209
'org.apache.beam.sdk.testing.UsesMetricsPusher',
211210
'org.apache.beam.sdk.testing.UsesBundleFinalizer',
@@ -219,7 +218,6 @@ def commonRunnerV2ExcludeCategories = [
219218
'org.apache.beam.sdk.testing.UsesMapState',
220219
'org.apache.beam.sdk.testing.UsesMultimapState',
221220
'org.apache.beam.sdk.testing.UsesMetricsPusher',
222-
'org.apache.beam.sdk.testing.UsesOrderedListState',
223221
'org.apache.beam.sdk.testing.UsesTestStream',
224222
'org.apache.beam.sdk.testing.UsesTestStreamWithProcessingTime',
225223
'org.apache.beam.sdk.testing.UsesRequiresTimeSortedInput',
@@ -450,6 +448,9 @@ task validatesRunner {
450448
description "Validates Dataflow runner"
451449
dependsOn(createLegacyWorkerValidatesRunnerTest(
452450
name: 'validatesRunnerLegacyWorkerTest',
451+
excludedCategories: [
452+
'org.apache.beam.sdk.testing.UsesMultimapState',
453+
],
453454
excludedTests: [
454455
// TODO(https://github.com/apache/beam/issues/21472)
455456
'org.apache.beam.sdk.transforms.GroupByKeyTest$BasicTests.testAfterProcessingTimeContinuationTriggerUsingState',
@@ -475,9 +476,7 @@ task validatesRunnerStreaming {
475476
pipelineOptions: legacyPipelineOptions + ['--streaming'],
476477
excludedCategories: [
477478
'org.apache.beam.sdk.testing.UsesCommittedMetrics',
478-
'org.apache.beam.sdk.testing.UsesMapState',
479479
'org.apache.beam.sdk.testing.UsesRequiresTimeSortedInput',
480-
'org.apache.beam.sdk.testing.UsesSetState',
481480
],
482481
excludedTests: [
483482
// TODO(https://github.com/apache/beam/issues/21472)

0 commit comments

Comments
 (0)