Skip to content

Commit fbaedc3

Browse files
committed
Enable some MapState, SetState, MultimapState validates runner tests for dataflow.
1 parent f41cbde commit fbaedc3

File tree

5 files changed

+8
-25
lines changed

5 files changed

+8
-25
lines changed
Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
{
2-
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
32
"comment": "Modify this file in a trivial way to cause this test suite to run",
4-
"modification": 2,
5-
"https://github.com/apache/beam/pull/34294": "noting that PR #34294 should run this test",
6-
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface"
3+
"modification": 3,
74
}
Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
11
{
2-
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
32
"comment": "Modify this file in a trivial way to cause this test suite to run",
4-
"https://github.com/apache/beam/pull/31156": "noting that PR #31156 should run this test",
5-
"https://github.com/apache/beam/pull/31268": "noting that PR #31268 should run this test",
6-
"https://github.com/apache/beam/pull/31490": "noting that PR #31490 should run this test",
7-
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface",
8-
"https://github.com/apache/beam/pull/36631": "dofn lifecycle",
3+
"modification": 1,
94
}
Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
11
{
2-
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
32
"comment": "Modify this file in a trivial way to cause this test suite to run",
4-
"https://github.com/apache/beam/pull/31156": "noting that PR #31156 should run this test",
5-
"https://github.com/apache/beam/pull/31268": "noting that PR #31268 should run this test",
6-
"https://github.com/apache/beam/pull/31490": "noting that PR #31490 should run this test",
7-
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface",
8-
"https://github.com/apache/beam/pull/36631": "dofn lifecycle validation",
3+
"modification": 2
94
}
Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
{
2-
"https://github.com/apache/beam/pull/34902": "Introducing OutputBuilder",
32
"comment": "Modify this file in a trivial way to cause this test suite to run",
4-
"https://github.com/apache/beam/pull/31156": "noting that PR #31156 should run this test",
5-
"https://github.com/apache/beam/pull/31268": "noting that PR #31268 should run this test",
6-
"https://github.com/apache/beam/pull/31490": "noting that PR #31490 should run this test"
3+
"modification": 1,
74
}

runners/google-cloud-dataflow-java/build.gradle

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ test {
7171
systemProperty "beamTestPipelineOptions", ""
7272
systemProperty "beamUseDummyRunner", "true"
7373
useJUnit {
74-
excludeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
74+
excludedCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
7575
}
7676
}
7777

@@ -203,7 +203,6 @@ def commonLegacyExcludeCategories = [
203203
'org.apache.beam.sdk.testing.UsesExternalService',
204204
'org.apache.beam.sdk.testing.UsesDistributionMetrics',
205205
'org.apache.beam.sdk.testing.UsesGaugeMetrics',
206-
'org.apache.beam.sdk.testing.UsesMultimapState',
207206
'org.apache.beam.sdk.testing.UsesTestStream',
208207
'org.apache.beam.sdk.testing.UsesMetricsPusher',
209208
'org.apache.beam.sdk.testing.UsesBundleFinalizer',
@@ -217,7 +216,6 @@ def commonRunnerV2ExcludeCategories = [
217216
'org.apache.beam.sdk.testing.UsesMapState',
218217
'org.apache.beam.sdk.testing.UsesMultimapState',
219218
'org.apache.beam.sdk.testing.UsesMetricsPusher',
220-
'org.apache.beam.sdk.testing.UsesOrderedListState',
221219
'org.apache.beam.sdk.testing.UsesTestStream',
222220
'org.apache.beam.sdk.testing.UsesTestStreamWithProcessingTime',
223221
'org.apache.beam.sdk.testing.UsesRequiresTimeSortedInput',
@@ -448,6 +446,9 @@ task validatesRunner {
448446
description "Validates Dataflow runner"
449447
dependsOn(createLegacyWorkerValidatesRunnerTest(
450448
name: 'validatesRunnerLegacyWorkerTest',
449+
excludedCategories: [
450+
'org.apache.beam.sdk.testing.UsesMultimapState',
451+
],
451452
excludedTests: [
452453
// TODO(https://github.com/apache/beam/issues/21472)
453454
'org.apache.beam.sdk.transforms.GroupByKeyTest$BasicTests.testAfterProcessingTimeContinuationTriggerUsingState',
@@ -473,9 +474,7 @@ task validatesRunnerStreaming {
473474
pipelineOptions: legacyPipelineOptions + ['--streaming'],
474475
excludedCategories: [
475476
'org.apache.beam.sdk.testing.UsesCommittedMetrics',
476-
'org.apache.beam.sdk.testing.UsesMapState',
477477
'org.apache.beam.sdk.testing.UsesRequiresTimeSortedInput',
478-
'org.apache.beam.sdk.testing.UsesSetState',
479478
],
480479
excludedTests: [
481480
// TODO(https://github.com/apache/beam/issues/21472)

0 commit comments

Comments
 (0)