CASSJAVA-89 Fix remove deprecated config chunk_length_kb #2029
Conversation
mkars10
force-pushed
the
CASSJAVA-89-deprecated-feature
branch
from
4ab80fa to
be6cd82
Compare
...y-builder/src/main/java/com/datastax/oss/driver/api/querybuilder/schema/RelationOptions.java
Outdated
Show resolved
Hide resolved
...y-builder/src/main/java/com/datastax/oss/driver/api/querybuilder/schema/RelationOptions.java
Outdated
Show resolved
Hide resolved
...y-builder/src/main/java/com/datastax/oss/driver/api/querybuilder/schema/RelationOptions.java
Show resolved
Hide resolved
...y-builder/src/main/java/com/datastax/oss/driver/api/querybuilder/schema/RelationOptions.java
Outdated
Show resolved
Hide resolved
...y-builder/src/main/java/com/datastax/oss/driver/api/querybuilder/schema/RelationOptions.java
Show resolved
Hide resolved
...y-builder/src/main/java/com/datastax/oss/driver/api/querybuilder/schema/RelationOptions.java
Show resolved
Hide resolved
|
@tolbertam thanks for the review! I addressed most of your points. Lmk about the Zstd compressor, if I'm being dense and there's a better way, I'm all for it. |
Changes looking good to me. I'm out of town until Monday, but I'll work to find a second reviewer and do some testing with it when I get back. |
There was a problem hiding this comment.
Would you be open to adding an integration test to check query-builder paths? It would be good to get a test failure on future syntax changes like this one, rather than discovering the issue later when attempting to startup an application on the newer Cassandra version. You could follow com.datastax.oss.driver.querybuilder.JsonInsertIT as an example.
There was a problem hiding this comment.
That's a good idea. It looks like I need to do some more local setup to get integration tests running though. I can take a look at that in a few days.
There was a problem hiding this comment.
Docs here: https://github.com/apache/cassandra-java-driver/blob/4.x/CONTRIBUTING.md#integration-tests
Let me know if you have any questions - happy to help you get set up.
There was a problem hiding this comment.
@aratno I added 3 integration tests to cover the following cases.
- top-level
crc_check_chancefor C* >= 3.0 chunk_length_in_kbfor C* >= 5.0chunk_length_kbfor C* < 5.0
...y-builder/src/main/java/com/datastax/oss/driver/api/querybuilder/schema/RelationOptions.java
Outdated
Show resolved
Hide resolved
...y-builder/src/main/java/com/datastax/oss/driver/api/querybuilder/schema/RelationOptions.java
Outdated
Show resolved
Hide resolved
mkars10
force-pushed
the
CASSJAVA-89-deprecated-feature
branch
from
5d1b0ff to
c182aa0
Compare
This fixes CASSJAVA-89 by switching from deprecated
chunk_length_kbtochunk_length_in_kb