Skip to content

Commit 3de13b0

Browse files
Clarify KVM import template requirement
1 parent f6efda5 commit 3de13b0

2 files changed

Lines changed: 37 additions & 1 deletion

File tree

api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ImportUnmanagedInstanceCmd.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ public class ImportUnmanagedInstanceCmd extends BaseAsyncCmd {
115115
@Parameter(name = ApiConstants.TEMPLATE_ID,
116116
type = CommandType.UUID,
117117
entityType = TemplateResponse.class,
118-
description = "The ID of the Template for the Instance")
118+
description = "The ID of the Template for the Instance. Required when importing an unmanaged KVM Instance.")
119119
private Long templateId;
120120

121121
@Parameter(name = ApiConstants.SERVICE_OFFERING_ID,
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
// Licensed to the Apache Software Foundation (ASF) under one
2+
// or more contributor license agreements. See the NOTICE file
3+
// distributed with this work for additional information
4+
// regarding copyright ownership. The ASF licenses this file
5+
// to you under the Apache License, Version 2.0 (the
6+
// "License"); you may not use this file except in compliance
7+
// with the License. You may obtain a copy of the License at
8+
//
9+
// http://www.apache.org/licenses/LICENSE-2.0
10+
//
11+
// Unless required by applicable law or agreed to in writing,
12+
// software distributed under the License is distributed on an
13+
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
14+
// KIND, either express or implied. See the License for the
15+
// specific language governing permissions and limitations
16+
// under the License.
17+
18+
package org.apache.cloudstack.api.command.admin.vm;
19+
20+
import java.lang.reflect.Field;
21+
22+
import org.apache.cloudstack.api.Parameter;
23+
import org.junit.Assert;
24+
import org.junit.Test;
25+
26+
public class ImportUnmanagedInstanceCmdTest {
27+
28+
@Test
29+
public void testTemplateIdDescriptionMentionsKvmRequirement() throws NoSuchFieldException {
30+
Field templateIdField = ImportUnmanagedInstanceCmd.class.getDeclaredField("templateId");
31+
Parameter parameter = templateIdField.getAnnotation(Parameter.class);
32+
33+
Assert.assertNotNull(parameter);
34+
Assert.assertTrue(parameter.description().contains("Required when importing an unmanaged KVM Instance."));
35+
}
36+
}

0 commit comments

Comments
 (0)