Replace remove method with expunge in deleteOauthProvider and add corresponding unit test

Author: Damans227

plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/OAuth2AuthManagerImpl.java

@@ -236,7 +236,7 @@ private OauthProviderVO saveOauthProvider(String provider, String description, S
 
     @Override
     public boolean deleteOauthProvider(Long id) {
-        return _oauthProviderDao.remove(id);
+        return _oauthProviderDao.expunge(id);
     }
 
     @Override

plugins/user-authenticators/oauth2/src/test/java/org/apache/cloudstack/oauth2/OAuth2AuthManagerImplTest.java

@@ -176,6 +176,18 @@ public void testListOauthProviders() {
         assertEquals(providerList, result);
     }
 
+    @Test
+    public void testDeleteOauthProviderHardDeletes() {
+        Long providerId = 42L;
+        when(_oauthProviderDao.expunge(providerId)).thenReturn(true);
+
+        boolean result = _authManager.deleteOauthProvider(providerId);
+
+        assertTrue(result);
+        Mockito.verify(_oauthProviderDao).expunge(providerId);
+        Mockito.verify(_oauthProviderDao, Mockito.never()).remove(Mockito.anyLong());
+    }
+
     @Test
     public void testGetCommands() {
         List<Class<?>> expectedCmdList = new ArrayList<>();