Add domain path handling to OAuth provider commands and improve descriptions

Author: Damans227

plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/OAuth2AuthManagerImpl.java

@@ -147,7 +147,7 @@ public OauthProviderVO registerOauthProvider(RegisterOAuthProviderCmd cmd) {
         String clientId = StringUtils.trim(cmd.getClientId());
         String redirectUri = StringUtils.trim(cmd.getRedirectUri());
         String secretKey = StringUtils.trim(cmd.getSecretKey());
-        Long domainId = cmd.getDomainId();
+        Long domainId = resolveDomainIdFromIdOrPath(cmd.getDomainId(), cmd.getDomainPath());
 
         if (!isOAuthPluginEnabled(domainId)) {
             throw new CloudRuntimeException("OAuth is not enabled, please enable to register");
@@ -265,6 +265,20 @@ public Long resolveDomainId(Map<String, Object[]> params) {
         return null;
     }
 
+    protected Long resolveDomainIdFromIdOrPath(Long domainId, String domainPath) {
+        if (domainId != null) {
+            return domainId;
+        }
+        String path = normalizeDomainPath(domainPath);
+        if (StringUtils.isNotEmpty(path)) {
+            Domain domain = _domainService.findDomainByIdOrPath(null, path);
+            if (Objects.nonNull(domain)) {
+                return domain.getId();
+            }
+        }
+        return null;
+    }
+
     protected String normalizeDomainPath(String path) {
         if (StringUtils.isEmpty(path)) {
             return null;

plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/api/command/ListOAuthProvidersCmd.java

@@ -68,7 +68,7 @@ public class ListOAuthProvidersCmd extends BaseListCmd implements APIAuthenticat
     private Long domainId;
 
     @Parameter(name = ApiConstants.DOMAIN, type = CommandType.STRING,
-            description = "Domain path for domain-specific OAuth provider lookup", since = "4.23.0")
+            description = "Domain path for domain-specific OAuth provider lookup. Ignored when Domain ID is passed.", since = "4.23.0")
     private String domainPath;
 
     /////////////////////////////////////////////////////

plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/api/command/RegisterOAuthProviderCmd.java

@@ -63,6 +63,10 @@ public class RegisterOAuthProviderCmd extends BaseCmd {
             description = "Domain ID for domain-specific OAuth provider. If not provided, registers as global provider", since = "4.23.0")
     private Long domainId;
 
+    @Parameter(name = ApiConstants.DOMAIN, type = CommandType.STRING,
+            description = "Domain path for domain-specific OAuth provider. Ignored when Domain ID is passed.", since = "4.23.0")
+    private String domainPath;
+
     @Parameter(name = ApiConstants.DETAILS, type = CommandType.MAP,
             description = "Any OAuth provider details in key/value pairs using format details[i].keyname=keyvalue. Example: details[0].clientsecret=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")
     protected Map details;
@@ -96,6 +100,10 @@ public Long getDomainId() {
         return domainId;
     }
 
+    public String getDomainPath() {
+        return domainPath;
+    }
+
     public Map getDetails() {
         if (MapUtils.isEmpty(details)) {
             return null;